-
Notifications
You must be signed in to change notification settings - Fork 468
chore(aap): fix threshold check for body on api10 #15488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 246 ± 2 ms. The average import time from base is: 249 ± 3 ms. The import time difference between this PR and base is: -3.3 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate christophe-papazian/fix_api10_bug (a5bbdc8) with baseline main (5b28231) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.397µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.6% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.4% ✅ add_inplace_aspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.1% Memory: ✅ 40.364MB (SLO: <41.500MB -2.7%) vs baseline: +4.4% ✅ add_inplace_noaspectTime: ✅ 0.317µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.3% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.7% ✅ add_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.5% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ bytearray_aspectTime: ✅ 1.350µs (SLO: <10.000µs 📉 -86.5%) vs baseline: ~same Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.1% ✅ bytearray_extend_aspectTime: ✅ 1.504µs (SLO: <10.000µs 📉 -85.0%) vs baseline: -1.2% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.0% ✅ bytearray_extend_noaspectTime: ✅ 0.614µs (SLO: <10.000µs 📉 -93.9%) vs baseline: +0.4% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.1% ✅ bytearray_noaspectTime: ✅ 0.485µs (SLO: <10.000µs 📉 -95.2%) vs baseline: +0.3% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.4% ✅ bytes_aspectTime: ✅ 1.301µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +1.6% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% ✅ bytes_noaspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.0% Memory: ✅ 40.049MB (SLO: <41.500MB -3.5%) vs baseline: +4.4% ✅ bytesio_aspectTime: ✅ 1.350µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +3.3% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +3.8% ✅ bytesio_noaspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.2% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% ✅ capitalize_aspectTime: ✅ 0.732µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.2% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +3.6% ✅ capitalize_noaspectTime: ✅ 0.429µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -1.3% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +5.2% ✅ casefold_aspectTime: ✅ 0.739µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.7% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +3.8% ✅ casefold_noaspectTime: ✅ 0.374µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.5% Memory: ✅ 40.069MB (SLO: <41.500MB -3.4%) vs baseline: +4.5% ✅ decode_aspectTime: ✅ 0.722µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.6% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +5.2% ✅ decode_noaspectTime: ✅ 0.415µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.6% Memory: ✅ 40.364MB (SLO: <41.500MB -2.7%) vs baseline: +5.2% ✅ encode_aspectTime: ✅ 0.707µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -1.3% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +5.0% ✅ encode_noaspectTime: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.7% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 3.441µs (SLO: <10.000µs 📉 -65.6%) vs baseline: +0.2% Memory: ✅ 40.088MB (SLO: <41.500MB -3.4%) vs baseline: +4.5% ✅ format_map_aspectTime: ✅ 3.538µs (SLO: <10.000µs 📉 -64.6%) vs baseline: -1.2% Memory: ✅ 40.383MB (SLO: <41.500MB -2.7%) vs baseline: +4.9% ✅ format_map_noaspectTime: ✅ 0.772µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.7% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 0.599µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.7% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ index_aspectTime: ✅ 0.357µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.5% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ index_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -1.2% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +5.1% ✅ join_aspectTime: ✅ 1.343µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +0.2% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.8% ✅ join_noaspectTime: ✅ 0.488µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.3% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +4.8% ✅ ljust_aspectTime: ✅ 2.899µs (SLO: <20.000µs 📉 -85.5%) vs baseline: 📈 +13.6% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +4.6% ✅ ljust_noaspectTime: ✅ 0.403µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.8% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.4% ✅ lower_aspectTime: ✅ 2.306µs (SLO: <10.000µs 📉 -76.9%) vs baseline: +2.5% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.6% ✅ lower_noaspectTime: ✅ 0.366µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.3% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +4.9% ✅ lstrip_aspectTime: ✅ 2.255µs (SLO: <20.000µs 📉 -88.7%) vs baseline: +0.4% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.8% ✅ lstrip_noaspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.5% Memory: ✅ 40.069MB (SLO: <41.500MB -3.4%) vs baseline: +4.7% ✅ modulo_aspectTime: ✅ 1.056µs (SLO: <10.000µs 📉 -89.4%) vs baseline: +5.2% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.541µs (SLO: <10.000µs 📉 -84.6%) vs baseline: -0.9% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.6% ✅ modulo_aspect_for_bytesTime: ✅ 0.986µs (SLO: <10.000µs 📉 -90.1%) vs baseline: +1.6% Memory: ✅ 40.344MB (SLO: <41.500MB -2.8%) vs baseline: +4.5% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.238µs (SLO: <10.000µs 📉 -87.6%) vs baseline: +2.0% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.9% ✅ modulo_noaspectTime: ✅ 0.624µs (SLO: <10.000µs 📉 -93.8%) vs baseline: ~same Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ replace_aspectTime: ✅ 4.869µs (SLO: <10.000µs 📉 -51.3%) vs baseline: -0.9% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +5.1% ✅ replace_noaspectTime: ✅ 0.463µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +1.0% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +5.1% ✅ repr_aspectTime: ✅ 0.909µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.4% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ repr_noaspectTime: ✅ 0.417µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.4% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ rstrip_aspectTime: ✅ 1.938µs (SLO: <20.000µs 📉 -90.3%) vs baseline: -0.9% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.5% ✅ rstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +1.0% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ slice_aspectTime: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.6% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.8% ✅ slice_noaspectTime: ✅ 0.450µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +1.1% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% ✅ stringio_aspectTime: ✅ 1.531µs (SLO: <10.000µs 📉 -84.7%) vs baseline: -0.5% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ stringio_noaspectTime: ✅ 0.720µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +1.5% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +5.1% ✅ strip_aspectTime: ✅ 2.243µs (SLO: <20.000µs 📉 -88.8%) vs baseline: ~same Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.9% ✅ strip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.3% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.5% ✅ swapcase_aspectTime: ✅ 2.774µs (SLO: <10.000µs 📉 -72.3%) vs baseline: 📈 +12.2% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +4.8% ✅ swapcase_noaspectTime: ✅ 0.542µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.3% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ title_aspectTime: ✅ 2.432µs (SLO: <10.000µs 📉 -75.7%) vs baseline: +2.7% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.4% ✅ title_noaspectTime: ✅ 0.507µs (SLO: <10.000µs 📉 -94.9%) vs baseline: +1.0% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.8% ✅ translate_aspectTime: ✅ 3.325µs (SLO: <10.000µs 📉 -66.7%) vs baseline: +0.7% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ translate_noaspectTime: ✅ 1.041µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.3% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +5.3% ✅ upper_aspectTime: ✅ 2.318µs (SLO: <10.000µs 📉 -76.8%) vs baseline: +4.2% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ upper_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.9% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.194µs (SLO: <10.000µs 📉 -48.1%) vs baseline: 📈 +26.5% Memory: ✅ 40.442MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.2% ✅ ospathbasename_noaspectTime: ✅ 1.081µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.3% Memory: ✅ 40.108MB (SLO: <41.000MB -2.2%) vs baseline: +4.4% ✅ ospathjoin_aspectTime: ✅ 6.126µs (SLO: <10.000µs 📉 -38.7%) vs baseline: -1.0% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.3% ✅ ospathjoin_noaspectTime: ✅ 2.282µs (SLO: <10.000µs 📉 -77.2%) vs baseline: -0.5% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.1% ✅ ospathnormcase_aspectTime: ✅ 3.445µs (SLO: <10.000µs 📉 -65.5%) vs baseline: +0.9% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.3% ✅ ospathnormcase_noaspectTime: ✅ 0.569µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.9% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathsplit_aspectTime: ✅ 4.710µs (SLO: <10.000µs 📉 -52.9%) vs baseline: -0.6% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.5% ✅ ospathsplit_noaspectTime: ✅ 1.598µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.1% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.3% ✅ ospathsplitdrive_aspectTime: ✅ 3.618µs (SLO: <10.000µs 📉 -63.8%) vs baseline: -1.0% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.703µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.8% Memory: ✅ 40.147MB (SLO: <41.000MB -2.1%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.513µs (SLO: <10.000µs 📉 -54.9%) vs baseline: ~same Memory: ✅ 40.108MB (SLO: <41.000MB -2.2%) vs baseline: +4.6% ✅ ospathsplitext_noaspectTime: ✅ 1.377µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -0.1% Memory: ✅ 40.383MB (SLO: <41.000MB 🟡 -1.5%) vs baseline: +5.2% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.402µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +15.4% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.3% ✅ 1-count-metrics-100-timesTime: ✅ 201.628µs (SLO: <220.000µs -8.4%) vs baseline: -0.4% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.299µs (SLO: <20.000µs 📉 -83.5%) vs baseline: ~same Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.4% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.852µs (SLO: <230.000µs -5.3%) vs baseline: -0.4% Memory: ✅ 35.095MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.6% ✅ 1-gauge-metric-1-timesTime: ✅ 2.153µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -1.1% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.987µs (SLO: <150.000µs -9.3%) vs baseline: -0.4% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.086µs (SLO: <20.000µs 📉 -84.6%) vs baseline: +1.1% Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.6% ✅ 1-rate-metrics-100-timesTime: ✅ 215.080µs (SLO: <250.000µs 📉 -14.0%) vs baseline: -0.4% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.5% ✅ 100-count-metrics-100-timesTime: ✅ 20.420ms (SLO: <22.000ms -7.2%) vs baseline: ~same Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.278ms (SLO: <2.300ms 🟡 -1.0%) vs baseline: ~same Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.5% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.402ms (SLO: <1.550ms -9.6%) vs baseline: ~same Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +4.5% ✅ 100-rate-metrics-100-timesTime: ✅ 2.228ms (SLO: <2.550ms 📉 -12.6%) vs baseline: +0.9% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +4.7% ✅ flush-1-metricTime: ✅ 4.603µs (SLO: <20.000µs 📉 -77.0%) vs baseline: -1.1% Memory: ✅ 35.095MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 174.823µs (SLO: <250.000µs 📉 -30.1%) vs baseline: -0.2% Memory: ✅ 35.114MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.181ms (SLO: <2.500ms 📉 -12.8%) vs baseline: +0.1% Memory: ✅ 35.940MB (SLO: <36.500MB 🟡 -1.5%) vs baseline: +4.9% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
A little bug was introduced in #15443
This PR:
No need to add a release note, as the previous PR was not released yet.
Testing
System tests.
APPSEC-60136