-
Notifications
You must be signed in to change notification settings - Fork 469
chore(profiling): improve typing in profiler.py #15499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(profiling): improve typing in profiler.py #15499
Conversation
|
|
951afa5 to
7413526
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 250 ± 4 ms. The average import time from base is: 253 ± 4 ms. The import time difference between this PR and base is: -2.8 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
367b8ce to
90ffd14
Compare
Performance SLOsComparing candidate kowalski/chore-profiling-improve-typing-in-profiler-py (7b318ae) with baseline main (ba60fe5) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.188µs (SLO: <10.000µs 📉 -48.1%) vs baseline: 📈 +25.4% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.7% ✅ ospathbasename_noaspectTime: ✅ 1.085µs (SLO: <10.000µs 📉 -89.1%) vs baseline: -0.5% Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +5.1% ✅ ospathjoin_aspectTime: ✅ 6.189µs (SLO: <10.000µs 📉 -38.1%) vs baseline: +0.9% Memory: ✅ 40.442MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.2% ✅ ospathjoin_noaspectTime: ✅ 2.290µs (SLO: <10.000µs 📉 -77.1%) vs baseline: -0.8% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.462µs (SLO: <10.000µs 📉 -65.4%) vs baseline: +1.0% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.569µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +0.3% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.718µs (SLO: <10.000µs 📉 -52.8%) vs baseline: -0.9% Memory: ✅ 40.108MB (SLO: <41.000MB -2.2%) vs baseline: +4.7% ✅ ospathsplit_noaspectTime: ✅ 1.592µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.4% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 3.658µs (SLO: <10.000µs 📉 -63.4%) vs baseline: +0.2% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 0.704µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.5% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 4.478µs (SLO: <10.000µs 📉 -55.2%) vs baseline: -1.3% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.6% ✅ ospathsplitext_noaspectTime: ✅ 1.374µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -0.9% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.8% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.419µs (SLO: <20.000µs 📉 -82.9%) vs baseline: 📈 +17.6% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.4% ✅ 1-count-metrics-100-timesTime: ✅ 203.187µs (SLO: <220.000µs -7.6%) vs baseline: +0.8% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.8% ✅ 1-distribution-metric-1-timesTime: ✅ 3.308µs (SLO: <20.000µs 📉 -83.5%) vs baseline: ~same Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.373µs (SLO: <230.000µs -5.5%) vs baseline: -0.1% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.4% ✅ 1-gauge-metric-1-timesTime: ✅ 2.181µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +0.4% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.185µs (SLO: <150.000µs -9.2%) vs baseline: ~same Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 3.135µs (SLO: <20.000µs 📉 -84.3%) vs baseline: +2.0% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 218.448µs (SLO: <250.000µs 📉 -12.6%) vs baseline: +2.0% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ 100-count-metrics-100-timesTime: ✅ 20.373ms (SLO: <22.000ms -7.4%) vs baseline: +0.4% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.273ms (SLO: <2.300ms 🟡 -1.2%) vs baseline: -1.0% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.404ms (SLO: <1.550ms -9.4%) vs baseline: +0.5% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.206ms (SLO: <2.550ms 📉 -13.5%) vs baseline: +0.3% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.625µs (SLO: <20.000µs 📉 -76.9%) vs baseline: -0.6% Memory: ✅ 35.114MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 175.351µs (SLO: <250.000µs 📉 -29.9%) vs baseline: +0.8% Memory: ✅ 35.114MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.8% ✅ flush-1000-metricsTime: ✅ 2.198ms (SLO: <2.500ms 📉 -12.1%) vs baseline: +0.8% Memory: ✅ 35.920MB (SLO: <36.500MB 🟡 -1.6%) vs baseline: +5.0% 🟡 Near SLO Breach (16 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
7b318ae to
9e7c80a
Compare
Description
https://datadoghq.atlassian.net/browse/PROF-13197
WIP