-
Notifications
You must be signed in to change notification settings - Fork 469
fix(avro): return result of wrapped serialize/deserialize when DSM enabled #15503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 246 ± 3 ms. The average import time from base is: 248 ± 3 ms. The import time difference between this PR and base is: -1.9 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate rob.carlan/fix-avro-dsm-method-return (e05782e) with baseline main (f29d01d) ❌ Test Failures (2 suites)❌ flasksimple - 17/18✅ appsec-getTime: ✅ 3.375ms (SLO: <4.750ms 📉 -28.9%) vs baseline: -0.3% Memory: ✅ 55.430MB (SLO: <66.500MB 📉 -16.6%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 2.853ms (SLO: <6.750ms 📉 -57.7%) vs baseline: ~same Memory: ✅ 55.566MB (SLO: <66.500MB 📉 -16.4%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 3.392ms (SLO: <4.750ms 📉 -28.6%) vs baseline: +0.4% Memory: ✅ 55.433MB (SLO: <66.500MB 📉 -16.6%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.868ms (SLO: <2.000ms -6.6%) vs baseline: ~same Memory: ✅ 47.884MB (SLO: <49.500MB -3.3%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: -0.1% Memory: ✅ 44.561MB (SLO: <49.000MB -9.1%) vs baseline: +5.0% ❌ profilerTime: ✅ 1.916ms (SLO: <2.100ms -8.8%) vs baseline: +0.4% Memory: ❌ 50.962MB (SLO: <50.000MB +1.9%) vs baseline: +4.4% ✅ resource-renamingTime: ✅ 3.357ms (SLO: <3.650ms -8.0%) vs baseline: -0.2% Memory: ✅ 55.512MB (SLO: <56.000MB 🟡 -0.9%) vs baseline: +5.0% ✅ tracerTime: ✅ 3.375ms (SLO: <3.650ms -7.5%) vs baseline: +0.1% Memory: ✅ 55.373MB (SLO: <56.500MB 🟡 -2.0%) vs baseline: +4.6% ✅ tracer-nativeTime: ✅ 3.378ms (SLO: <3.650ms -7.4%) vs baseline: +0.3% Memory: ✅ 55.391MB (SLO: <60.000MB -7.7%) vs baseline: +4.6% ❌ recursivecomputation - 7/8✅ deepTime: ✅ 309.375ms (SLO: <320.950ms -3.6%) vs baseline: ~same Memory: ✅ 35.920MB (SLO: <36.500MB 🟡 -1.6%) vs baseline: +4.9% ❌ deep-profiledTime: ✅ 326.619ms (SLO: <359.150ms -9.1%) vs baseline: -0.3% Memory: ❌ 41.614MB (SLO: <40.500MB +2.7%) vs baseline: +5.0% ✅ mediumTime: ✅ 7.008ms (SLO: <7.400ms -5.3%) vs baseline: +0.3% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ shallowTime: ✅ 0.946ms (SLO: <1.050ms -9.9%) vs baseline: +1.1% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +4.6% 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.5% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.6% ✅ add_inplace_aspectTime: ✅ 0.403µs (SLO: <10.000µs 📉 -96.0%) vs baseline: ~same Memory: ✅ 40.521MB (SLO: <41.500MB -2.4%) vs baseline: +4.6% ✅ add_inplace_noaspectTime: ✅ 0.323µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +1.8% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.2% ✅ add_noaspectTime: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -1.0% Memory: ✅ 40.305MB (SLO: <41.500MB -2.9%) vs baseline: +5.1% ✅ bytearray_aspectTime: ✅ 1.353µs (SLO: <10.000µs 📉 -86.5%) vs baseline: -0.2% Memory: ✅ 40.541MB (SLO: <41.500MB -2.3%) vs baseline: +5.8% ✅ bytearray_extend_aspectTime: ✅ 1.499µs (SLO: <10.000µs 📉 -85.0%) vs baseline: -0.8% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.0% ✅ bytearray_extend_noaspectTime: ✅ 0.609µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -1.0% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +4.0% ✅ bytearray_noaspectTime: ✅ 0.484µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -1.3% Memory: ✅ 40.049MB (SLO: <41.500MB -3.5%) vs baseline: +4.2% ✅ bytes_aspectTime: ✅ 1.284µs (SLO: <10.000µs 📉 -87.2%) vs baseline: +0.4% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +3.9% ✅ bytes_noaspectTime: ✅ 0.496µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.0% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +5.0% ✅ bytesio_aspectTime: ✅ 1.347µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +2.0% Memory: ✅ 40.462MB (SLO: <41.500MB -2.5%) vs baseline: +5.1% ✅ bytesio_noaspectTime: ✅ 0.504µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.6% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.7% ✅ capitalize_aspectTime: ✅ 0.737µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.1% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +3.8% ✅ capitalize_noaspectTime: ✅ 0.438µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +1.0% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 0.737µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -1.3% Memory: ✅ 40.383MB (SLO: <41.500MB -2.7%) vs baseline: +5.3% ✅ casefold_noaspectTime: ✅ 0.372µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.6% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +5.0% ✅ decode_aspectTime: ✅ 0.727µs (SLO: <10.000µs 📉 -92.7%) vs baseline: ~same Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +3.7% ✅ decode_noaspectTime: ✅ 0.416µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -1.0% Memory: ✅ 40.344MB (SLO: <41.500MB -2.8%) vs baseline: +5.3% ✅ encode_aspectTime: ✅ 0.710µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.5% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.1% ✅ encode_noaspectTime: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.1% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 3.412µs (SLO: <10.000µs 📉 -65.9%) vs baseline: ~same Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.6% ✅ format_map_aspectTime: ✅ 3.511µs (SLO: <10.000µs 📉 -64.9%) vs baseline: -2.0% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +5.0% ✅ format_map_noaspectTime: ✅ 0.774µs (SLO: <10.000µs 📉 -92.3%) vs baseline: +0.1% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +4.5% ✅ format_noaspectTime: ✅ 0.595µs (SLO: <10.000µs 📉 -94.1%) vs baseline: ~same Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +5.3% ✅ index_aspectTime: ✅ 0.355µs (SLO: <10.000µs 📉 -96.5%) vs baseline: ~same Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.3% ✅ index_noaspectTime: ✅ 0.279µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.9% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +5.0% ✅ join_aspectTime: ✅ 1.345µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +0.6% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.6% ✅ join_noaspectTime: ✅ 0.492µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.5% Memory: ✅ 40.324MB (SLO: <41.500MB -2.8%) vs baseline: +5.1% ✅ ljust_aspectTime: ✅ 2.928µs (SLO: <20.000µs 📉 -85.4%) vs baseline: 📈 +14.0% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.4% ✅ ljust_noaspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.3% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ lower_aspectTime: ✅ 2.285µs (SLO: <10.000µs 📉 -77.2%) vs baseline: +0.6% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.8% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ lstrip_aspectTime: ✅ 2.241µs (SLO: <20.000µs 📉 -88.8%) vs baseline: ~same Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.6% ✅ lstrip_noaspectTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.2% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 1.054µs (SLO: <10.000µs 📉 -89.5%) vs baseline: +5.5% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +3.8% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.534µs (SLO: <10.000µs 📉 -84.7%) vs baseline: -1.5% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +5.0% ✅ modulo_aspect_for_bytesTime: ✅ 0.975µs (SLO: <10.000µs 📉 -90.2%) vs baseline: -0.2% Memory: ✅ 40.324MB (SLO: <41.500MB -2.8%) vs baseline: +4.9% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.235µs (SLO: <10.000µs 📉 -87.7%) vs baseline: +1.5% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.9% ✅ modulo_noaspectTime: ✅ 0.629µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.2% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ replace_aspectTime: ✅ 4.864µs (SLO: <10.000µs 📉 -51.4%) vs baseline: -1.4% Memory: ✅ 40.442MB (SLO: <41.500MB -2.5%) vs baseline: +5.3% ✅ replace_noaspectTime: ✅ 0.460µs (SLO: <10.000µs 📉 -95.4%) vs baseline: ~same Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +5.2% ✅ repr_aspectTime: ✅ 0.908µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.3% Memory: ✅ 40.324MB (SLO: <41.500MB -2.8%) vs baseline: +4.6% ✅ repr_noaspectTime: ✅ 0.415µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.4% Memory: ✅ 40.305MB (SLO: <41.500MB -2.9%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 1.949µs (SLO: <20.000µs 📉 -90.3%) vs baseline: +0.8% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 0.379µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.6% Memory: ✅ 40.324MB (SLO: <41.500MB -2.8%) vs baseline: +5.3% ✅ slice_aspectTime: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.6% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.4% ✅ slice_noaspectTime: ✅ 0.448µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.7% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.9% ✅ stringio_aspectTime: ✅ 1.537µs (SLO: <10.000µs 📉 -84.6%) vs baseline: +0.3% Memory: ✅ 40.541MB (SLO: <41.500MB -2.3%) vs baseline: +5.8% ✅ stringio_noaspectTime: ✅ 0.720µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.6% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.8% ✅ strip_aspectTime: ✅ 2.263µs (SLO: <20.000µs 📉 -88.7%) vs baseline: +1.9% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.9% ✅ strip_noaspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +5.0% ✅ swapcase_aspectTime: ✅ 2.504µs (SLO: <10.000µs 📉 -75.0%) vs baseline: +2.4% Memory: ✅ 40.521MB (SLO: <41.500MB -2.4%) vs baseline: +5.7% ✅ swapcase_noaspectTime: ✅ 0.539µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.8% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ title_aspectTime: ✅ 2.427µs (SLO: <10.000µs 📉 -75.7%) vs baseline: +1.6% Memory: ✅ 40.344MB (SLO: <41.500MB -2.8%) vs baseline: +5.3% ✅ title_noaspectTime: ✅ 0.500µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -1.0% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ translate_aspectTime: ✅ 3.307µs (SLO: <10.000µs 📉 -66.9%) vs baseline: ~same Memory: ✅ 40.560MB (SLO: <41.500MB -2.3%) vs baseline: +5.6% ✅ translate_noaspectTime: ✅ 1.041µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.2% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.1% ✅ upper_aspectTime: ✅ 2.307µs (SLO: <10.000µs 📉 -76.9%) vs baseline: +2.2% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ upper_noaspectTime: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.6% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.194µs (SLO: <10.000µs 📉 -48.1%) vs baseline: 📈 +25.9% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.3% ✅ ospathbasename_noaspectTime: ✅ 1.083µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.8% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 6.160µs (SLO: <10.000µs 📉 -38.4%) vs baseline: -0.3% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.3% ✅ ospathjoin_noaspectTime: ✅ 2.306µs (SLO: <10.000µs 📉 -76.9%) vs baseline: +1.4% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.435µs (SLO: <10.000µs 📉 -65.7%) vs baseline: -0.6% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.2% ✅ ospathnormcase_noaspectTime: ✅ 0.569µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +0.5% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.1% ✅ ospathsplit_aspectTime: ✅ 4.744µs (SLO: <10.000µs 📉 -52.6%) vs baseline: -0.9% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.2% ✅ ospathsplit_noaspectTime: ✅ 1.597µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.2% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.2% ✅ ospathsplitdrive_aspectTime: ✅ 3.667µs (SLO: <10.000µs 📉 -63.3%) vs baseline: +0.1% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.698µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.7% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.477µs (SLO: <10.000µs 📉 -55.2%) vs baseline: -0.9% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.3% ✅ ospathsplitext_noaspectTime: ✅ 1.375µs (SLO: <10.000µs 📉 -86.3%) vs baseline: ~same Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.1% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.404µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +14.8% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.6% ✅ 1-count-metrics-100-timesTime: ✅ 199.848µs (SLO: <220.000µs -9.2%) vs baseline: -1.3% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +4.1% ✅ 1-distribution-metric-1-timesTime: ✅ 3.301µs (SLO: <20.000µs 📉 -83.5%) vs baseline: +0.4% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.5% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.194µs (SLO: <230.000µs -5.6%) vs baseline: -0.1% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.167µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -0.6% Memory: ✅ 34.682MB (SLO: <35.500MB -2.3%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.831µs (SLO: <150.000µs -8.8%) vs baseline: ~same Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ 1-rate-metric-1-timesTime: ✅ 3.107µs (SLO: <20.000µs 📉 -84.5%) vs baseline: +0.5% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.3% ✅ 1-rate-metrics-100-timesTime: ✅ 214.234µs (SLO: <250.000µs 📉 -14.3%) vs baseline: -0.4% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ 100-count-metrics-100-timesTime: ✅ 20.491ms (SLO: <22.000ms -6.9%) vs baseline: +1.1% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.273ms (SLO: <2.550ms 📉 -10.8%) vs baseline: -0.3% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.404ms (SLO: <1.550ms -9.4%) vs baseline: -0.1% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.224ms (SLO: <2.550ms 📉 -12.8%) vs baseline: ~same Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.602µs (SLO: <20.000µs 📉 -77.0%) vs baseline: -0.4% Memory: ✅ 35.114MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 173.921µs (SLO: <250.000µs 📉 -30.4%) vs baseline: ~same Memory: ✅ 35.154MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.174ms (SLO: <2.500ms 📉 -13.1%) vs baseline: -0.7% Memory: ✅ 35.999MB (SLO: <36.500MB 🟡 -1.4%) vs baseline: +5.3% 🟡 Near SLO Breach (14 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
brettlangdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit, but otherwise lgtm
dubloom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a test could be indeed nice but otherwise LGTM !
(For the prechecks failure, just merging main should fix this)
Description
When DSM is enabled, we aren't returning the function result for
DatumReader.readandDatumWriter.write. This fixes that to make it consistent with the default behavior.Testing
Risks
Additional Notes