Skip to content

chore: default off CLL full map cache#1245

Merged
kentwelcome merged 2 commits intomainfrom
chore/default-off-cll-full-map-cache
Mar 25, 2026
Merged

chore: default off CLL full map cache#1245
kentwelcome merged 2 commits intomainfrom
chore/default-off-cll-full-map-cache

Conversation

@wcchang1115
Copy link
Collaborator

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

chore

What this PR does / why we need it:

Changes the pre-cached full column-level lineage map (build_full_cll_map) to be disabled by default. Previously, get_cll() would eagerly build the entire project's CLL map upfront and slice from it. Now it uses the per-node path by default, avoiding the upfront computation cost for large projects.

  • Renamed CLI flag from --disable-cll-cache to --enable-cll-cache (env: ENABLE_CLL_CACHE)
  • Default: cache OFF (per-node CLL computation)
  • Opt-in: recce server --enable-cll-cache to restore previous behavior

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

  • Only recce/cli.py is changed — the get_cll() method signature and disable_cll_cache parameter are unchanged
  • Frontend never sent full_map, so no frontend impact
  • MCP server calls get_cll() directly without the flag, so it already used the per-node path
  • Existing tests parametrize both cached and uncached paths via the disable_cll_cache fixture, no test changes needed

Does this PR introduce a user-facing change?:

The --disable-cll-cache CLI flag is replaced by --enable-cll-cache. The CLL full map cache is now off by default.

🤖 Generated with Claude Code

Change the pre-cached full column-level lineage map (build_full_cll_map)
to be disabled by default. Rename CLI flag from --disable-cll-cache to
--enable-cll-cache for users who want to opt in.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
recce/cli.py 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
recce/cli.py 52.76% <66.66%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@kentwelcome kentwelcome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcchang1115 wcchang1115 self-assigned this Mar 25, 2026
@kentwelcome kentwelcome merged commit f773e83 into main Mar 25, 2026
19 checks passed
@kentwelcome kentwelcome deleted the chore/default-off-cll-full-map-cache branch March 25, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants