0.16.2: exclude chromedriver from pub package + multi-session edge-case tests#295
Merged
Conversation
Add three integration tests to the Multi-session group covering the PR #294 review fixes: abandoning a stream releases the mutex (C2, no deadlock), closing a session mid-generation is safe (C5, no use-after-free), and openSession rejects image/audio loudly on the text-only .litertlm virtual path.
The chromedriver binary (a maintainer tool for running web integration tests via `flutter drive -d chrome`) sits at repo root and is ~16 MB. It leaked into the published package, bloating the archive to 8 MB. Add `chromedriver/` to .pubignore — archive drops to ~683 KB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two post-merge follow-ups for 0.16.2:
chromedriver/from the pub package. The chromedriver binary (a maintainer tool forflutter drive -d chromeweb integration tests) sits at repo root (~16 MB) and leaked into the published archive, bloating it to 8 MB. With it ignored the archive drops to ~683 KB.dart pub publish --dry-run: 0 warnings..litertlmvirtual path. Verified 23/23 on macOS.