Skip to content

Add generics to Constructor#5

Open
XedinUnknown wants to merge 6 commits into0.1.xfrom
task/constructor-generics
Open

Add generics to Constructor#5
XedinUnknown wants to merge 6 commits into0.1.xfrom
task/constructor-generics

Conversation

@XedinUnknown
Copy link
Member

This allows static analysis to deduce the type of the service
that will be created from a Constructor definition.

This allows static analysis to deduce the type of the service
that will be created from a `Constructor` definition.
@XedinUnknown XedinUnknown added this to the v0.1 milestone Apr 9, 2021
@XedinUnknown XedinUnknown requested a review from mecha April 9, 2021 10:19
@XedinUnknown XedinUnknown self-assigned this Apr 9, 2021
Copy link
Member

@mecha mecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mecha
mecha previously approved these changes Apr 10, 2021
I guess, in `class-string<T>`, `T` must be of type `object`.

See vimeo/psalm#3933.
I guess, in `class-string<T>`, `T` must be of type `object`.

See vimeo/psalm#3933.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments