You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That would work. I wanted to keep the current resolveDeps() because I can see its utility. Given ["foo", "bar"] it returns ["foo" => ..., "bar" => ...], which makes a lot of sense. This is why I added a new method. A consumer may want to access the services by their key after passing them through resolveDeps().
On the other hand, there is nothing that is currently utilizing the service keys in the resolveDeps() return value. And realistically, there may not be. Given that this trait is used for service helpers, it's unlikely that individual services will be extracted from the returned array. So it could be changed to preserve the keys in the argument array.
But if we're going to do that, I think we could just use array_map. The immediately-invoked function and the creation of a Generator becomes obsolete and unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6