Option to allow geyser clients with a file patcher.#85
Option to allow geyser clients with a file patcher.#85Abdo9616 wants to merge 3 commits intoDiffuseHyperion:masterfrom
Conversation
Added
Changed
Fixed
|
|
|
||
| [geyser] | ||
| # Whether to allow Geyser clients (Bedrock players) to join the server. (Floodgate is required) | ||
| allow_geyser_clients = false (Warning: Extra security risk, use at your own risk) |
| /.idea/ | ||
| /runClient/ | ||
| /runServer/ | ||
| Command.bat |
There was a problem hiding this comment.
i assume you forgot to remove this before commiting
|
|
||
| boolean allowGeyserClients = InertiaAntiCheatServer.serverConfig.getBoolean("geyser.allow_geyser_clients", false); | ||
| UpgradedServerLoginNetworkHandler upgradedHandler = (UpgradedServerLoginNetworkHandler) handler; | ||
| net.minecraft.network.ClientConnection connection = upgradedHandler.inertiaAntiCheat$getConnection(); |
There was a problem hiding this comment.
please import the classes instead
DiffuseHyperion
left a comment
DiffuseHyperion
left a comment
There was a problem hiding this comment.
theres a bunch of illogical code and code that doesnt follow the standards of the rest of the project
i appreciate your effort in submitting this, but this is not ready to be merged into the project
| @@ -0,0 +1,104 @@ | |||
| package com.diffusehyperion.inertiaanticheat.server; | |||
There was a problem hiding this comment.
whats the point of this? can't the floodgate api be imported as a gradle dependency?
| Toml config = new Toml().read(configFile); | ||
| if (!Objects.equals(config.getLong("debug.version", 0L), currentConfigVersion)) { | ||
| warn("Looks like your config file is outdated! Backing up current config, then creating an updated config."); | ||
| boolean versionMismatch = !Objects.equals(config.getLong("debug.version", 0L), currentConfigVersion); |
There was a problem hiding this comment.
this feature isn't part of the main feature proposed in the pr (afaik), please open another pr instead
currently, i'm unwilling to add a config file patcher to avoid the possibility of the config file getting messed up without the user's knowledge.
2 participants
Added
allow_geyser_clientsconfiguration option to allow Bedrock Edition players to join servers[geyser]allow_geyser_clients = false(defaults to disabled for security)Changed
ServerLoginModlistTransferHandler.checkConnection()to respect Geyser client settingsTechnical Details
ConfigPatcherutility class for automatic configuration managementInertiaAntiCheatServerinitialization to run config patches on startup