feat(settings): Custom workspace worktree folder can be configured#549
feat(settings): Custom workspace worktree folder can be configured#549Thlnking wants to merge 5 commits intoDimillian:mainfrom
Conversation
Add custom worktree folder settings at the workspace level, overriding global settings. Add a worktree folder input box and browse button for each project in the settings interface. Update the backend logic to prioritize workspace settings, followed by global settings, and finally the default location.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52f6df3d66
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…worktrees folder When renaming a worktree, the priority logic now follows the same as add_worktree_core: first use the workspace-specific settings, then use the global settings, and finally fallback to the default path. This ensures that the renaming operation uses the same storage location as the adding operation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dda908daf7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b822a6f4dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb4ccf48fe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/features/settings/components/sections/SettingsEnvironmentsSection.tsx
Show resolved
Hide resolved
…ng tree. Fixed the issue where the validity of the parent repository's working tree directory was not verified during renaming of the working tree. Now, the directory will be checked for existence and accessibility first, and the operation will fail early if it is invalid, to avoid inconsistencies in the state if the working tree fails to move after the branch has been renamed. New test cases have been added to verify this scenario.
2 participants
Add custom worktree folder settings at the workspace level, overriding global settings. Add a worktree folder input box and browse button for each project in the settings interface. Update the backend logic to prioritize workspace settings, followed by global settings, and finally the default location.