Adds Backstage OOC chat#1033
Conversation
github-actions
Bot
added
Sprites
| GLOBAL_LIST_INIT(sooc_job_lookup, list( | ||
| JOB_CAPTAIN = TRUE, | ||
| JOB_HEAD_OF_SECURITY = TRUE, | ||
| JOB_WARDEN = TRUE, | ||
| JOB_DETECTIVE = TRUE, | ||
| JOB_SECURITY_OFFICER = TRUE, | ||
| JOB_COMMAND_BODYGUARD = TRUE, | ||
| )) |
There was a problem hiding this comment.
there's an argument to be made about adding the sophont resources officer, cause they're supposed to mediate/negotiate with security in a bunch of situations
also, I just realized, it's kinda awkward that the captain gets access to this but like acting captains don't really, do they? honestly unsure how best to fix that.
the Easy one would be "all command" for backstage, but that'd include a bunch of like non acting captain people-- but like there's an argument to be made for including all command in backstage anyway, cause it Will be all of their problems too if anything meaningful enough goes down
There was a problem hiding this comment.
I feel we gotta commit to calling this backstage in code, rather than flip flopping on asooc or backstage
| var/color = (!anon && CONFIG_GET(flag/allow_admin_ooccolor) && iterated_client?.prefs?.read_preference(/datum/preference/color/ooc_color)) ? iterated_client?.prefs?.read_preference(/datum/preference/color/ooc_color) : GLOB.backstage_color[red_or_blue] | ||
| var/name = (mode == LISTEN_ADMIN && anon) ? "([key])[keyname]" : keyname | ||
| var/chat_icon = (is_admin(mob.client) && !GLOB.deadmins[mob.client?.ckey]) ? icon2html(MODULAR_EMOJI_SET, world, "dolphin") : icon2html(red_or_blue == ASOOC_RED ? EMOJI_SET : MODULAR_EMOJI_SET, world, red_or_blue == ASOOC_RED ? "pop" : "blorbo") | ||
| to_chat(iterated_client, span_oocplain("<font color='[color]'> [chat_icon] <EM>[name]</EM> says, <b><span class='message linkify'>[msg]</span></b></font>")) |
There was a problem hiding this comment.
this should probably also use the span_[X](...) type defines
https://github.com/DopplerShift13/DopplerShift/blob/master/code/__DEFINES/span.dm
<EM> iirc is span_italic(...), <b> being span_bold(...), the message and linkify ones also being their own ones
probably a bit awkward here, but like, we're setting the name var directly above anyway
I'd probably do
var/namepart = span_italic(name)
var/msgpart = span_bold(span_message(span_linkify(msg)))
to_chat(iterated_client, span_oocplain("<font color='[color]'> [chat_icon] [namepart] says, [msgpart]</font>"))or y'know make out own span_backstage(...) define for this so we can have msgpart = span_backstage(msg) instead of this mess
| for(var/iterated_listener as anything in listeners) | ||
| var/client/iterated_client = iterated_listener |
There was a problem hiding this comment.
am i tripping or like doesn't as anything let you do
for(var/client/iterated_client as anything in listeners)|
|
||
| for(var/iterated_listener as anything in listeners) | ||
| var/client/iterated_client = iterated_listener | ||
| var/mode = listeners[iterated_listener] |
There was a problem hiding this comment.
nitpick: var/listening_mode
| /datum/computer_file/program/emojipedia/New() | ||
| . = ..() | ||
| var/list/extra = icon_states(icon(MODULAR_EMOJI_SET)) | ||
| emoji_list |= extra |
There was a problem hiding this comment.
doesn't this Still have the issue of adding to a static list every time the program is created?
| /datum/keybinding/client/communication/backstage | ||
| hotkey_keys = list("ShiftO") | ||
| name = BACKSTAGE_CHANNEL | ||
| full_name = "Backstage OOC (SAOOC)" |
There was a problem hiding this comment.
and here we say SAOOC instead of ASOOC or Backstage
probably just edit this to "Backstage OOC (Antag/Sec)" parallel to the verb's naming scheme
github-actions
Bot
added
the
Sound
|
Hello??? fucking peak??? |
3 participants
About The Pull Request
Adds an antag and security combined OOC channel, and an emoji. Also, ghosts can see SOOC, AOOC and backstage unless they disable OOC sight.
Why It's Good For The Game
It was requested of me to add a combined antag and security OOC channel. It makes sense to coordinate RP better.
I personally find the formatting to be improved, and I think its fun for ghosts to see the OOC channels. After all, it just helps them know what they're getting into may they wish to join.
Testing Evidence
untitled.webm
Changelog
🆑
add: Backstage OOC channel for antags and security
qol: Ghosts can eavesdrop on AOOC, SOOC and backstage
add: :blorbo: emoji
/:cl: