add permission to increase entity view count#14
Open
walterjenner wants to merge 1 commit intoDrupalHub:7.x-1.xfrom
Open
add permission to increase entity view count#14walterjenner wants to merge 1 commit intoDrupalHub:7.x-1.xfrom
walterjenner wants to merge 1 commit intoDrupalHub:7.x-1.xfrom
Conversation
|
First - thank you for the PR. The idea is good but I think that by default we want to know how many times an entity was viewed. Can you please add an update hook that add the permission to all the roles as well during the install? 10x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a permission to control who can increase the entity view count allows to only count hits from certain user roles.
One can ignore the hits of admin users for example.