Skip to content

ingress: Correct propagation option for other providers #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

ingress: Correct propagation option for other providers #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion custom-domain/dstack-ingress/scripts/certman.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,10 @@ def _build_certbot_command(self, action: str, domain: str, email: str) -> List[s
if os.environ.get("CERTBOT_STAGING", "false") == "true":
base_cmd.extend(["--staging"])

base_cmd.extend(["--dns-cloudflare-propagation-seconds=120"])
if getattr(self.provider, 'CERTBOT_PROPAGATION_SECONDS'):
propagation_seconds = self.provider.CERTBOT_PROPAGATION_SECONDS
propagation_param = f"--dns-{self.provider_type}-propagation-seconds={propagation_seconds}"
base_cmd.extend([propagation_param])

# Log command with masked email for debugging
masked_cmd = [arg if not (i > 0 and base_cmd[i-1] == "--email") else "<email>"
Expand Down
Loading