feat:add global rate limiting with @nestjs/throttler (closes #10)#16
Open
adarshdotdev wants to merge 1 commit intoDyan-Dev:mainfrom
Open
feat:add global rate limiting with @nestjs/throttler (closes #10)#16adarshdotdev wants to merge 1 commit intoDyan-Dev:mainfrom
adarshdotdev wants to merge 1 commit intoDyan-Dev:mainfrom
Conversation
Contributor
|
This PR looks good, but it adds the rate limiting globally to all the APIs internal API's as well. We need rate limiting for dynamic endpoints. |
Contributor
Author
|
To clarify:
confirm if this matches expectation before proceed. |
Contributor
|
No, you’re applying the Can you check again? Also, you can see that you’re applying rate limiting to other endpoints, for example, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements global rate limiting for the backend API using
@nestjs/throttler. The configuration is set to allow a maximum of 5 requests per second per IP address, helping to prevent abuse of dynamic endpoints.Key changes:
@nestjs/throttleras a backend dependency.ThrottlerModuleinapp.module.tswithlimit: 5andtimeToLive: 1.ThrottlerGuardas a global guard to enforce rate limiting on all routes.Testing:
429 Too Many Requestsresponse.screenshort

Closes: #10
Let me know if you want to add or change anything!