Skip to content

Conversation

Copy link

Copilot AI commented Dec 11, 2025

Addresses review feedback from PR #62 regarding a misleading variable name in the storage class change loop.

Changes

  • Renamed objects_changedprocessed_count in the main processing loop (lines 338, 350)

The variable is a 1-indexed loop counter tracking iteration progress, not a count of successfully changed objects. Success/failure counts are tracked separately in stats["succeeded"] and stats["failed"].

# Before
for objects_changed, (obj_key, current_class) in enumerate(objects_to_change, start=1):
    # ...
    if objects_changed % 100 == 0 or objects_changed == len(objects_to_change):

# After  
for processed_count, (obj_key, current_class) in enumerate(objects_to_change, start=1):
    # ...
    if processed_count % 100 == 0 or processed_count == len(objects_to_change):

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Address feedback on OVH Cloud storage class improvements Rename misleading loop counter variable in storage tier change script Dec 11, 2025
Copilot AI requested a review from lhoupert December 11, 2025 11:15
@lhoupert lhoupert marked this pull request as ready for review December 11, 2025 11:16
@lhoupert lhoupert merged commit e85d340 into fix--fix-unnecessary-api-call-to-get-the-storage-class-for-each-object Dec 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants