included tol limit #339
Merged
included tol limit #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧹 Catalogue's Preview Site CleanupThe preview site for this pull request has been cleaned up. If you need a new preview, please reopen the PR or create a new one. |
HansVRP
reviewed
Jan 29, 2026
...hm_catalog/vito/random_forest_firemapping/benchmark_scenarios/random_forest_firemapping.json
Show resolved
Hide resolved
HansVRP
reviewed
Jan 29, 2026
| "job-results.json": "https://s3.waw3-1.cloudferro.com/swift/v1/apex-examples/whittaker/job-results.json" | ||
| }, | ||
| "reference_options": { | ||
| "atol": 0.1 |
Contributor
There was a problem hiding this comment.
any specific reason why atol is prefered over rtol?
Contributor
Author
There was a problem hiding this comment.
no reason a specific reason, I simply followed couple of examples and thought absolute check is preferred. Will update if rtol is preferred one
EmileSonneveld
approved these changes
Jan 30, 2026
Contributor
Author
|
@EmileSonneveld resolved conflit and avoided tolerance in here |
EmileSonneveld
approved these changes
Jan 30, 2026
Contributor
Author
|
Since it has been approved, I will hopefully merge it. Please let me know if you have additional suggestions @HansVRP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced tolerance limit in the benchmark