Conversation
3 tasks
doyeonk429
reviewed
Feb 12, 2025
Member
There was a problem hiding this comment.
내부 함수와 외부에서 호출할 함수를 명확하게 잘 나누신 것 같습니다! Good!!
doyeonk429
reviewed
Feb 12, 2025
Comment on lines
27
to
45
Member
There was a problem hiding this comment.
입력받는 걸 함수화할 수도 있지 않을까요? print문으로 출력할 메세지만 파라미터로 받는다던가, 출력문을 미리 Enum으로 정의해둔다거나 등의 방법으로요!
doyeonk429
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
🎨 스크린샷
|
💬 추가 설명
다음엔 조금 더 열심히 하도록 하겠습니다.