Clarify environment-scoped config and validate missing settings#189
Merged
elasticdog merged 2 commits intomainfrom Feb 12, 2026
Merged
Clarify environment-scoped config and validate missing settings#189elasticdog merged 2 commits intomainfrom
elasticdog merged 2 commits intomainfrom
Conversation
This was only working coincidentally for our signing setup, the values weren't actually being passed through from the caller repository.
github-actions
bot
added
documentation
elasticdog
added a commit
to EarthmanMuons/whatchord
that referenced
this pull request
Feb 12, 2026
The signing was only working previously by coincidence, since we moved these values into a repository environment, they aren't actually available here in the call site, only inside of the jobs defined in the reusable workflows, so we rely on convention, documentation, and validation on the other side to ensure we've done this correctly for both the signing and release environmental jobs. See: - EarthmanMuons/reusable-workflows#189
github-merge-queue bot
pushed a commit
to EarthmanMuons/whatchord
that referenced
this pull request
Feb 12, 2026
The signing was only working previously by coincidence, since we moved these values into a repository environment, they aren't actually available here in the call site, only inside of the jobs defined in the reusable workflows, so we rely on convention, documentation, and validation on the other side to ensure we've done this correctly for both the signing and release environmental jobs. See: - EarthmanMuons/reusable-workflows#189
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.