feat(cpn): make possible to use same scale in Log Viewer #6818
Conversation
pfeerick
changed the title
pfeerick
added
companion
|
Have you considered putting 'Use common axis' checkbox on the same line as Zoom and expand Reset to also reset the new checkbox? |
I’ve moved the checkbox to the row above and updated the Reset button handler — it now resets the checkbox states as well. Here’s how it looks now. Note: I also added some spacing between the "X/Y" checkboxes and the “Use common Y axis” checkbox. |
Reset checkboxes state on 'Reset' button click
| default: | ||
| break; | ||
| if (!useCommonAxes) { | ||
| switch (plots.coords[i].yaxis) { |
There was a problem hiding this comment.
line 977 2 spaces to left
| auto [min, max] = this->GetMinMaxY(); | ||
| axisRect->axis(QCPAxis::atLeft)->setRange(min, max); | ||
| } else { | ||
| axisRect->axis(QCPAxis::atLeft)->setRange(yAxesRanges[firstLeft].min, yAxesRanges[firstLeft].max); |
There was a problem hiding this comment.
line1046 2 spaces to left
elecpower
left a comment
elecpower
left a comment
There was a problem hiding this comment.
Thank you. I am so pleased to see someone helping out on the Companion side and has Qt experience.
3 participants
From bug #5216: Companion Log Viewer Scaling issue
Current Behavior
Depending the log file, the Viewer changes the scale from left to right what makes the selected (relevant) fields hard to read / compare. For example, selecting all Lipo Battery cells (C1-C6). File 073542, C5 and C6 are shown using the right scale while the others use the left scale as it supposed to see file 071847.
Expected Behavior
Use 1 scale for for all selected fields related to each other such as Lipo cells.
Summary of changes:
Use common axescheckbox was addedBefore:
After:
