BootcampReact - PR 1: Mini-Challenge 1#1
Open
EduGlzC wants to merge 2 commits into
Open
Conversation
ragrum
approved these changes
Mar 29, 2021
ragrum
left a comment
ragrum
left a comment
There was a problem hiding this comment.
Nice work on the UI, I'd like to see the work on the testing, too.
| 'If you think about it, just look it up', | ||
| ]; | ||
|
|
||
| function getRand(max) { |
There was a problem hiding this comment.
Perhaps a better name for this would be getRandomPlaceHolder and return the random placeholder text already.
| @@ -0,0 +1,11 @@ | |||
| import React from 'react'; | |||
|
|
|||
| const HeaderLogin = (props) => ( | |||
There was a problem hiding this comment.
You could destructure your props right here:
const HeaderLogin = ({ photo, message }) => (And then use photo and message instead of props.photo and props.message.
|
|
||
| const HeaderNav = (props) => ( | ||
| <div className="w-1/6"> | ||
| <div className=" h-10 w-10 flex items-cente justify-center p-1"> |
There was a problem hiding this comment.
There's a typo in items-cente, missing a r.
| @@ -0,0 +1,11 @@ | |||
| import React from 'react'; | |||
|
|
|||
| const HeaderNav = (props) => ( | |||
| @@ -1,4 +1,4 @@ | |||
| .container { | |||
| /*.container { | |||
There was a problem hiding this comment.
Do not keep commented out code, that's why you have your Git history.
| </div> | ||
| ); | ||
|
|
||
| // {videos.map((item) => ( |
EduGlzC
changed the title
EduGlzC
changed the title
ragrum
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core Concepts and Styling
The UI elements do not have functionality
The application has to read a local json file