Skip to content

Enable subcycle time stepping in CarpetX schedule#371

Open
lwJi wants to merge 42 commits intomainfrom
lwji/sc
Open

Enable subcycle time stepping in CarpetX schedule#371
lwJi wants to merge 42 commits intomainfrom
lwji/sc

Conversation

@lwJi
Copy link
Copy Markdown
Contributor

@lwJi lwJi commented Nov 25, 2025

Summary Refactored driver.cxx and schedule.cxx to enable subcycling support in CarpetX.

Change Log

  1. Regression Test: Added a WaveToyX test (3 refinement levels) to ensure backward compatibility.

  2. Parameter Scope: Promoted use_subcycling_wip to RESTRICTED scope for external thorn usage.

  3. Driver Logic: Enabled subcycling during regridding (provided levels align) in driver.cxx.

  4. Schedule Logic: Updated schedule.cxx to support the new subcycling flow.

  5. Unit Test: Added a new test case specifically for subcycle time stepping.

@lwJi lwJi requested review from eschnett and rhaas80 November 25, 2025 19:56
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx
Comment thread CarpetX/src/schedule.cxx
Comment thread TestSubcycling/test/subcycle/testsubcycling-iteration.it000008.z.tsv Outdated
Comment thread TestSubcycling/README Outdated
Comment thread WaveToyX/test/radiative-3levels.par
Comment thread WaveToyX/test/radiative-3levels.par
Comment thread CarpetX/param.ccl Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx
Comment thread WaveToyX/test/radiative-3levels.par Outdated
Comment thread TestSubcycling/schedule.ccl Outdated
Comment thread CarpetX/src/driver.hxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Copy link
Copy Markdown
Collaborator

@eschnett eschnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few suggestions. Please look at them, then merge.

Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread CarpetX/src/schedule.cxx
Comment thread CarpetX/src/schedule.cxx Outdated
Comment thread TestSubcycling/schedule.ccl Outdated
Comment thread TestSubcycleStepping/test/subcycle.par
Comment thread WaveToyX/test/radiative-3levels.par
Comment thread WaveToyX/test/radiative-3levels.par
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants