Conversation
rhaas80
requested changes
Nov 25, 2025
eschnett
reviewed
Nov 26, 2025
eschnett
reviewed
Nov 26, 2025
eschnett
reviewed
Nov 26, 2025
eschnett
reviewed
Nov 26, 2025
eschnett
reviewed
Nov 26, 2025
eschnett
reviewed
Nov 26, 2025
eschnett
reviewed
Nov 26, 2025
eschnett
reviewed
Nov 26, 2025
eschnett
reviewed
Nov 26, 2025
eschnett
reviewed
Nov 26, 2025
eschnett
reviewed
Nov 26, 2025
eschnett
reviewed
Nov 26, 2025
eschnett
reviewed
Nov 26, 2025
eschnett
reviewed
Feb 3, 2026
eschnett
reviewed
Feb 3, 2026
eschnett
reviewed
Feb 3, 2026
eschnett
reviewed
Feb 3, 2026
eschnett
reviewed
Feb 3, 2026
eschnett
reviewed
Feb 3, 2026
eschnett
reviewed
Feb 3, 2026
eschnett
reviewed
Feb 3, 2026
eschnett
approved these changes
Feb 3, 2026
Collaborator
eschnett
left a comment
There was a problem hiding this comment.
I made a few suggestions. Please look at them, then merge.
rhaas80
requested changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary Refactored
driver.cxxandschedule.cxxto enable subcycling support in CarpetX.Change Log
Regression Test: Added a WaveToyX test (3 refinement levels) to ensure backward compatibility.
Parameter Scope: Promoted
use_subcycling_wipto RESTRICTED scope for external thorn usage.Driver Logic: Enabled subcycling during regridding (provided levels align) in
driver.cxx.Schedule Logic: Updated
schedule.cxxto support the new subcycling flow.Unit Test: Added a new test case specifically for subcycle time stepping.