Prevent a call to a protected function to GameMenuFrame:SetHeight()#167
Open
Zelgunn wants to merge 1 commit intoEllesmereGaming:mainfrom
Open
Prevent a call to a protected function to GameMenuFrame:SetHeight()#167Zelgunn wants to merge 1 commit intoEllesmereGaming:mainfrom
Zelgunn wants to merge 1 commit intoEllesmereGaming:mainfrom
Conversation
…prevent a call to a protected function to GameMenuFrame:SetHeight())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now hiding EllesmereUI button in Game Menu if in combat lockdown (to prevent a call to a protected function to GameMenuFrame:SetHeight()).
The BugSack report:
This BugSack report was reported in the bug report "Buffbars dont find fixed anchor or smthg" (https://discord.com/channels/585577383847788554/1484220166718886119) but appears to be unrelated to the bug the user experienced.
To replicate the bug (before the fix):
EllesmereUI will be there but the Game Menu frame will have the default height.
Given EllesmereUI Options cannot be opened while in combat anyway, I went with hiding the button (and leaving the Game Menu frame in its original state, without the extra space for the addon's button)