Add Lag Tolerance Helper and recommendations#191
Open
Kneeull wants to merge 1 commit intoEllesmereGaming:mainfrom
Open
Add Lag Tolerance Helper and recommendations#191Kneeull wants to merge 1 commit intoEllesmereGaming:mainfrom
Kneeull wants to merge 1 commit intoEllesmereGaming:mainfrom
Conversation
Fixed Lag Tolerance resetting on every reload and added in a recommended Tolerance setting based on the users ping (scraped at game run time (on reload and game launch), however sometimes fails on first game launch, but works on a reload. This is due to how blizzard loads it after the user has entered the world)
Owner
|
went with a more simple fix for now, i will revisit the recommended tolerance concept later |
Owner
|
leaving this open for now |
Contributor
Author
|
All good - just noticed in the PR I've overwritten the wrong function - it's meant to be the one lower but the concept is the same ^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Lag Tolerance resetting on every reload and added in a recommended Tolerance setting based on the users ping (scraped at game run time (on reload and game launch), however sometimes fails on first game launch, but works on a reload. This is due to how blizzard loads it after the user has entered the world)