Account for Fortran assumed shape#2821
Draft
joewallwork wants to merge 3 commits into
Draft
Conversation
7cf1051 to
644ef32
Compare
Collaborator
Author
|
This all works well on it's own. However, I've just discovered that it doesn't work in conjunction with #2809. I tested this branch merged with that one on cases with assumed shape arrays and they compile but produce segfaults. This branch also produces a warning like for each assumed shape array encountered, which isn't ideal. For a full fix, we should address #2822. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2820.
As documented in the issue, I wasn't able to build the
allocatableArraySimpleexample locally. It seemed that Enzyme didn't fully account for assumed shape arrays in Fortran. The small patch in this PR addresses this and I can confirm I can now forward and reverse mode differentiate through things likewhich is really nice.
If I understand correctly, the error message I was hitting was slightly misleading so I propose an alternative phrasing.