Skip to content

Commit 4ea1a68

Browse files
committed
resolve based on comments
1 parent 72174b0 commit 4ea1a68

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

espresso/environment/optitmism_espresso_test_helpers.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -812,7 +812,7 @@ func ensureHardCodedPortsAreMappedFromTheirOriginalValues(containerInfo *DockerC
812812
}
813813
}
814814

815-
// launchEspressoDevNodeAndAttestationVerifierZKStartOption is E2eDevnetLauncherOption that launches th
815+
// launchEspressoDevNodeAndAttestationVerifierZKStartOption is E2eDevnetLauncherOption that launches the
816816
// Espresso Dev Node within a Docker container. It also ensures that the
817817
// Espresso Dev Node is actively producing blocks before returning.
818818
// Additionally, it launches the Attestation Verifier ZK server in a Docker container.
@@ -933,7 +933,6 @@ func launchEspressoDevNodeAndAttestationVerifierZKStartOption(ct *E2eDevnetLaunc
933933
// Use the actual host:port for health check
934934
attestationURL := "http://" + attestationHostPort
935935

936-
// url pf the attestation verifier zk server
937936
c.Espresso.EspressoAttestationService = attestationURL
938937

939938
for {
@@ -958,7 +957,7 @@ func launchEspressoDevNodeAndAttestationVerifierZKStartOption(ct *E2eDevnetLaunc
958957

959958
}
960959

961-
// launchEspressoDevNodeDocker is E2eDevnetLauncherOption that launches th
960+
// launchEspressoDevNodeAndAttestationVerifierZKStartOption is E2eDevnetLauncherOption that launches the
962961
// Espresso Dev Node within a Docker container. It also ensures that the
963962
// Espresso Dev Node is actively producing blocks before returning.
964963
func launchEspressoDevNodeAndAttestationServiceDocker() E2eDevnetLauncherOption {

op-batcher/batcher/driver.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@ type DriverSetup struct {
112112
}
113113

114114
type EspressoOnchainProof struct {
115-
Zktype string `json:"zktype"`
116-
ZkvmVersion string `json:"zkvm_version"`
115+
ZKType string `json:"zktype"`
116+
ZKVMVersion string `json:"zkvm_version"`
117117
ProgramID struct {
118118
VerifierID string `json:"verifier_id"`
119119
VerifierProofID string `json:"verifier_proof_id"`

op-batcher/batcher/espresso.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -962,7 +962,7 @@ func (l *BatchSubmitter) registerBatcher(ctx context.Context) error {
962962
l.Log.Info("Batch authenticator address", "value", l.RollupConfig.BatchAuthenticatorAddress)
963963
code, err := l.L1Client.CodeAt(ctx, l.RollupConfig.BatchAuthenticatorAddress, nil)
964964
if err != nil {
965-
return fmt.Errorf("failed to check code at contrat address: %w", err)
965+
return fmt.Errorf("failed to check code at contract address: %w", err)
966966
}
967967
if len(code) == 0 {
968968
return fmt.Errorf("no contract deployed at this address %w", err)

op-deployer/pkg/deployer/pipeline/espresso.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ func DeployEspresso(env *Env, intent *state.Intent, st *state.State, chainID com
3535
lgr.Info("Using nitro enclave verifier address from NITRO_ENCLAVE_VERIFIER_ADDRESS env var", "address", nitroEnclaveVerifierAddress.Hex())
3636
} else {
3737
lgr.Info("NITRO_ENCLAVE_VERIFIER_ADDRESS env var not set, using empty address")
38-
fmt.Printf("Nitro enclave verifier address not set")
3938
// this means we should deploy a mock verifier ( should only be used in dev / test environments
4039
nitroEnclaveVerifierAddress = common.Address{}
4140
}
@@ -47,7 +46,6 @@ func DeployEspresso(env *Env, intent *state.Intent, st *state.State, chainID com
4746
lgr.Info("Using enclave hash from ENCLAVE_HASH env var", "hash", common.Bytes2Hex(enclaveHash[:]))
4847
} else {
4948
lgr.Info("ENCLAVE_HASH env var not set, using zeroed hash")
50-
fmt.Printf("Enclave hash not set, using zeroed hash\n")
5149
}
5250

5351
var nvo opcm.DeployAWSNitroVerifierOutput

0 commit comments

Comments
 (0)