Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick disclaimer: this isn't quite ready to merge yet. for the time being, this PR is mainly for discussion and gathering feedback.
About Scenery Tiles
besides Solid and Background Tiles, a room has additional layers known as "Scenery Tiles", which are placed in the same way and have the feature of overlaying on the tiles beneath them, replacing their appearance.
there are three layers of Scenery Tiles:
Updateis called.the value of each Scenery Tile is an
integerwhich corresponds to which tile to use from the Scenery Tileset.-1means that no Scenery Tile is overlaid on that position.the Scenery Tileset is hardcoded for
"tilesets/scenery", but this PR aims to provide a way for mappers to set a custom path for it.SceneryTilesmetadatathis PR implements a new Map Meta property called
SceneryTiles, which takes astringvalue indicating the path, relative to the Gameplay atlas, for the custom texture to use. this will allow mappers to place their own tiles to overlay onto the terrain.Possible improvements?
while this has been a simple feature to implement, I've had some thoughts about how it could be improved.
as of now, the meta property just takes a path to a custom texture, but this might be better implemented as a new type of XML bank, providing more customisability for Scenery Tiles.
for example, one possible setting could be whether a tile should mask lighting or not.
an ability to use multiple Scenery Tilesets might also help for collabs where different maps would be brought together.
mods could also add their own options if desired.
of course, there's also the matter of supporting all this with map making tools like Lönn, but that's a topic for another time.
(by the way, I've written some Lönn plugins you could use to test it out. you can get them from my repositories)
for now, feel free to comment with more ways on how this feature could be improved