Skip to content

fix: Fix PrefabType invalid asset ID#803

Closed
Supper-Steve wants to merge 10 commits intoExMod-Team:masterfrom
CnCSharp-Dev:master
Closed

fix: Fix PrefabType invalid asset ID#803
Supper-Steve wants to merge 10 commits intoExMod-Team:masterfrom
CnCSharp-Dev:master

Conversation

@Supper-Steve
Copy link
Copy Markdown

@Supper-Steve Supper-Steve commented Apr 5, 2026

Description

Describe the changes

Fixed incorrect Asset IDs (the parameter "Asset Id" of PrefabAttribute) in PrefabType enum.
Specifically:

  • Fixed SzCameraToy asset ID.
  • Fixed TantrumObj asset ID.

What is the current behavior? (You can also link to an open issue here)

Some resource IDs of PrefabType entries are incorrect or duplicated, causing a NullReferenceException or incorrect generation of other prefabs.

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

fix: all firearm pickup
fix:
- Firearm pickups
- Ragdolls
- HCZ OneSided & HCZ TwoSided
- TantrumObj
- ChaosKeycardPickup replace KeycardPickup_Chaos 

Obsolete all types of special holidays.(If the holiday comes, then delete ObsoleteAttribute)
@github-actions github-actions bot added the API label Apr 5, 2026
@Supper-Steve Supper-Steve changed the title Fix: Update the asset id of 'PrefabType' fix: Fix PrefabType asset ID and remove obsolete types. Apr 5, 2026
Copy link
Copy Markdown

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can get that some of these are outdated but trust me there still ragdoll and pickup in the game that you can spawn

@Supper-Steve
Copy link
Copy Markdown
Author

Ragdolls have been changed to network messages PlayerRoles.Ragdolls.RagdollData. The client spawn the ragdoll after receiving the data packet.

@louis1706
Copy link
Copy Markdown

Ragdolls have been changed to network messages PlayerRoles.Ragdolls.RagdollData. The client spawn the ragdoll after receiving the data packet.

That false they still get spawn like that but required DataInfo on them to get spawn otherwise they get an error on client

@louis1706
Copy link
Copy Markdown

For Weapon is kinda the same they required to have a valid Attachement value

@louis1706 louis1706 added the Do not merge Don't merge this PR label Apr 5, 2026
@Supper-Steve Supper-Steve changed the title fix: Fix PrefabType asset ID and remove obsolete types. fix: Fix PrefabType invalid asset ID Apr 6, 2026
@Supper-Steve Supper-Steve requested a review from louis1706 April 6, 2026 03:09
@Supper-Steve
Copy link
Copy Markdown
Author

So I kept the deleted types. I only fixed the wrong assetid.

@louis1706
Copy link
Copy Markdown

AssetId was correct i verified rn

@louis1706 louis1706 closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Do not merge Don't merge this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants