feat: Changes to ReadPickupInfoBefore to include more information when converting between Pickup and Item.#804
Open
Saskyc wants to merge 1 commit intoExMod-Team:masterfrom
Open
Conversation
MS-crew
reviewed
Apr 7, 2026
Comment on lines
+131
to
+150
| /// <summary> | ||
| /// Gets or sets the damage for this <see cref="FirearmPickup"/>. | ||
| /// </summary> | ||
| public float Damage { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the inaccuracy for this <see cref="FirearmPickup"/>. | ||
| /// </summary> | ||
| public float Inaccuracy { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the penetration for this <see cref="FirearmPickup"/>. | ||
| /// </summary> | ||
| public float Penetration { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets how much fast the value drop over the distance. | ||
| /// </summary> | ||
| public float DamageFalloffDistance { get; set; } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Includes properties from HitscanHitregModule to FirearmPickup, so they're not resetted everytime firearm is dropped.
What is the current behavior? (You can also link to an open issue here)
X
What is the new behavior? (if this is a feature change)
X
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Noupe.
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other