Fix manual overcharge not working

[lL1l1]

Description of the proposed changes

Fix typo that made manual overcharge get stuck.

Testing done on the proposed changes

Manual overcharge works.

   CreateUnitAtMouse('xab1401', 0,  -18.00,    1.00, -0.00000)
   CreateUnitAtMouse('uel0001', 0,    6.00,    3.00,  2.74913)
   CreateUnitAtMouse('ueb2302', 1,   12.00,   -4.00,  3.14159)

Checklist

• Changes are annotated, including comments where useful: Annotate DefaultProjectileWeapon #7012
• Changes are documented in a changelog snippet according to the guidelines.
• Request 2-3 reviewers from the list of reviewers and their areas of knowledge.

Summary by CodeRabbit

• Bug Fixes

  • Manual overcharge now reliably triggers during combat.

• Documentation

  • Added a changelog entry describing the fix.

• Refactor

  • Normalized weapon metadata naming to ensure consistent behavior across systems.

[coderabbitai]

Warning

Rate limit exceeded

@lL1l1 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 15 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

Fixes a case-sensitivity mismatch for the OverCharge/Overcharge blueprint field used by weapon firing logic and adds a changelog entry documenting the manual overcharge firing fix.

Changes

Cohort / File(s)	Summary
Changelog changelog/snippets/fix.7031.md	Added snippet: "(#7031) Fix manual overcharge not shooting."
Weapon runtime fix lua/sim/weapons/DefaultProjectileWeapon.lua	Corrected conditional to use bp.OverChargeWeapon (case-sensitive) in RackSalvoFireReadyState to properly detect overcharge weapons.
Blueprint field rename engine/Core/Blueprints/WeaponBlueprint.lua	Renamed public field from OverchargeWeapon → OverChargeWeapon (case change) on WeaponBlueprint to match runtime checks.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Fix silos with delay before firing being able to fire twice #7010: Modifies the same RackSalvoFireReadyState busy-state logic and the Overcharge/OverCharge blueprint field references.

Suggested reviewers

• BlackYps
• 4z0t

Poem

🐰 A tiny cap, a sneaky miss,

Overcharge hid its firing bliss.
One letter nudged, the lines align,
Now rockets sing and stars will shine.
Rabbits clap — the fix is fine! ✨

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Fix manual overcharge not working' clearly and concisely summarizes the main change: fixing a typo that prevented manual overcharge functionality from working correctly.
Description check	✅ Passed	The description covers key sections including the change description, testing performed, and a completed checklist. However, the changelog snippet checkbox is marked incomplete despite the addition of changelog/snippets/fix.7031.md.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into develop

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[4z0t]

---@field NukeWeapon? boolean
---@field Overcharge? WeaponBlueprintOvercharge
--- overcharge weapon flag
---@field OverchargeWeapon? boolean
--- flag that specifies if the weapon prefers to target what the primary weapon is currently
--- targeting
---@field PrefersPrimaryWeaponTarget? boolean

In WeaponBlueprint.lua it also appears as a typo. Plesae add it to the fix as well.

[4z0t]

Update WeaponBlueprint.lua.

[4z0t]

Additionaly you can change all OverchargeWeapon to OverChargeWeapon for future. It appears to be OverchargeWeapon is used all over the codebase. So I'd rather change to it. But it may break sim mods...

[lL1l1]

I searched for OverchargeWeapon and overchargeWeapon (case sensitive), and I found that typo in the state machine doc but every other mention was a class name which can't be changed due to imports.