Round veterancy values to nearest integer

[NoryGit]

Example:

• Old HP of T2 Cybran ACU with 3 vets: 15599
• New HP of T2 Cybran ACU with 3 vets: 15600

Checklist

• Changes are annotated, including comments where useful
• Changes are documented in a changelog snippet according to the guidelines.
• Request 2-3 reviewers from the list of reviewers and their areas of knowledge.

Summary by CodeRabbit

• Bug Fixes
  • Max health calculations now round to whole numbers (no fractional HP), fixing veterancy health bonus inconsistencies and ensuring consistent unit HP values.
• Documentation
  • Added a changelog entry documenting the rounding fix with an example comparison.

[coderabbitai]

📝 Walkthrough

Walkthrough

The MaxHealth buff effect now rounds the value returned by BuffCalculate(...) using math.round(val) before calling unit:SetMaxHealth(val). A changelog snippet documenting the rounding fix for veterancy/max-health was added.

Changes

Cohort / File(s)	Summary
MaxHealth Buff Rounding lua/sim/Buff.lua	Round val from BuffCalculate(...) with math.round(val) before applying via unit:SetMaxHealth(val).
Changelog Snippet changelog/snippets/fix.7075.md	Add changelog entry describing veterancy/max-health rounding fix and example values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

area: balance idea

Poem

🐰 I hopped through code by lantern's glow,
Rounded health so numbers grow.
No halves remain, all whole and neat,
Small fixes make the balance sweet. 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description provides a concrete example of the change's effect but omits the 'Description of the proposed changes' and 'Testing done' sections from the template.	Add a clear description of what the changes do and document the testing performed to verify the rounding behavior works correctly.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately describes the main change: rounding veterancy values to the nearest integer, which is the core modification applied to the BuffEffects.MaxHealth effect in the Buff.lua file.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

lua/sim/Buff.lua (1)

304-305: Add boundary regression coverage for rounding behavior.

Please add/extend tests for .49, .50, .51 boundaries (including the documented 15599→15600 scenario) to lock in this behavior and prevent regressions.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lua/sim/Buff.lua` around lines 304 - 305, The rounding logic in Buff.lua uses
val = math.floor(val + 0.5) but lacks tests to lock in boundary behavior; add
unit tests that exercise the rounding at .49, .50 and .51 boundaries and the
documented 15599→15600 case. Specifically, create tests that call the
function/method that produces/consumes the local variable val (referencing the
rounding site where val = math.floor(val + 0.5)) with inputs that produce
fractional parts .49, .50 and .51 and assert they round to the expected integers
(e.g., x.49 -> x, x.50 -> x+1, x.51 -> x+1), and add an explicit test for the
15599.* inputs that verifies 15599.50 rounds to 15600 (and nearby .49/.51 behave
accordingly) to prevent regression.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@lua/sim/Buff.lua`:
- Around line 304-305: The rounding logic in Buff.lua uses val = math.floor(val
+ 0.5) but lacks tests to lock in boundary behavior; add unit tests that
exercise the rounding at .49, .50 and .51 boundaries and the documented
15599→15600 case. Specifically, create tests that call the function/method that
produces/consumes the local variable val (referencing the rounding site where
val = math.floor(val + 0.5)) with inputs that produce fractional parts .49, .50
and .51 and assert they round to the expected integers (e.g., x.49 -> x, x.50 ->
x+1, x.51 -> x+1), and add an explicit test for the 15599.* inputs that verifies
15599.50 rounds to 15600 (and nearby .49/.51 behave accordingly) to prevent
regression.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c320f551-2cc5-4173-bbe7-3fea3e8a35ac

📥 Commits

Reviewing files that changed from the base of the PR and between 132476b and 0a9d41c.

📒 Files selected for processing (1)

• lua/sim/Buff.lua