remove batch pending from fieldresult#64
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the pending_batch attribute from FieldResult and standardizes batch-comparator deferral on status="pending" (using the existing comparator field to identify the batch handler), simplifying the result model used throughout struct_extract_eval.
Changes:
- Removed
FieldResult.pending_batchand updated scoring to mark batch-comparator placeholders viastatus="pending". - Updated
process_batchesto find pending fields by status and group them byFieldResult.comparator. - Updated/adjusted batch-related tests and evaluator docstrings to reflect the new pending semantics.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_batch.py | Updates batch dispatch tests to construct pending placeholders without pending_batch. |
| src/struct_extract_eval/evaluator.py | Docstring update to describe pending resolution via status="pending". |
| src/struct_extract_eval/core/scoring.py | Removes pending_batch from FieldResult and updates batch-deferral behavior/docs. |
| src/struct_extract_eval/batch/process.py | Switches dispatch grouping from pending_batch to status="pending" + comparator. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
603
to
607
| if is_batch(comparator_fn): | ||
| # Defer: build a provisional FieldResult, mark pending. process_batches | ||
| # will dispatch this to the registered batch handler later. | ||
| # The comparator name identifies which batch handler to use. | ||
| return FieldResult( |
Collaborator
Author
There was a problem hiding this comment.
@copilot apply changes based on this feedback
Copilot stopped work on behalf of
yaruwangway due to an error
May 4, 2026 18:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.