Skip to content

build(deps-dev)!: replace glob with native glob#796

Open
Fdawgs wants to merge 1 commit into
mainfrom
build/glob
Open

build(deps-dev)!: replace glob with native glob#796
Fdawgs wants to merge 1 commit into
mainfrom
build/glob

Conversation

@Fdawgs
Copy link
Copy Markdown
Owner

@Fdawgs Fdawgs commented May 19, 2026

BREAKING CHANGE: minimum node version increased from 20 to 22.17.0

Not in a massive rush to merge this as it's just for tests and not functionality.

Checklist

Copilot AI review requested due to automatic review settings May 19, 2026 09:41
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the glob dev dependency by switching the test suite cleanup logic to Node’s native fs.promises.glob, and updates project tooling to require Node 22.17.0+.

Changes:

  • Replace glob package usage in test/index.test.js with node:fs/promises glob (async iterable).
  • Remove glob from devDependencies and bump the Node engine requirement to >=22.17.0.
  • Update local/CI Node version configuration (.nvmrc, CI matrix) accordingly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
test/index.test.js Uses fs.promises.glob in afterEach to find and delete leftover test files, and centralizes exclusion patterns.
package.json Removes glob devDependency and raises engines.node minimum to 22.17.0.
.nvmrc Pins local dev Node version to 22.17.0.
.github/workflows/ci.yml Drops Node 20 from the unit test matrix (now 22/24).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment thread .github/workflows/ci.yml
BREAKING CHANGE: minimum node version increased from 20 to 22.17.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants