build(deps-dev)!: replace glob with native glob#796
Open
Fdawgs wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the glob dev dependency by switching the test suite cleanup logic to Node’s native fs.promises.glob, and updates project tooling to require Node 22.17.0+.
Changes:
- Replace
globpackage usage intest/index.test.jswithnode:fs/promisesglob(async iterable). - Remove
globfromdevDependenciesand bump the Node engine requirement to>=22.17.0. - Update local/CI Node version configuration (
.nvmrc, CI matrix) accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/index.test.js |
Uses fs.promises.glob in afterEach to find and delete leftover test files, and centralizes exclusion patterns. |
package.json |
Removes glob devDependency and raises engines.node minimum to 22.17.0. |
.nvmrc |
Pins local dev Node version to 22.17.0. |
.github/workflows/ci.yml |
Drops Node 20 from the unit test matrix (now 22/24). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BREAKING CHANGE: minimum node version increased from 20 to 22.17.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: minimum node version increased from 20 to 22.17.0
Not in a massive rush to merge this as it's just for tests and not functionality.
Checklist
npm test