Skip to content

fix(index): ignore undefined options#569

Merged
Fdawgs merged 1 commit into
mainfrom
fix/undefined-options
May 7, 2026
Merged

fix(index): ignore undefined options#569
Fdawgs merged 1 commit into
mainfrom
fix/undefined-options

Conversation

@Fdawgs
Copy link
Copy Markdown
Owner

@Fdawgs Fdawgs commented May 7, 2026

Checklist

Copilot AI review requested due to automatic review settings May 7, 2026 14:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates option parsing so explicitly undefined option values are treated as “not provided” (rather than invalid), aligning with the API expectation that all CLI options are optional and preventing unnecessary validation errors.

Changes:

  • Skip option entries whose value is undefined during CLI arg generation.
  • Add a regression test ensuring { outputHtml: undefined } behaves the same as omitting options (default HTML output).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/index.js Updates parseOptions to ignore keys whose values are undefined, avoiding type/version validation for absent options.
test/index.test.js Adds coverage for outputHtml: undefined to ensure default HTML behavior remains intact.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Fdawgs Fdawgs merged commit 44508aa into main May 7, 2026
21 checks passed
@Fdawgs Fdawgs deleted the fix/undefined-options branch May 7, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants