chore!: consistent contract naming, add SignatureVerificationLib#388
Merged
Conversation
BREAKING change because it renames keys here but they are very inconsistent and confusing and the PDP ones don't even show you what the proxy is.
Collaborator
|
Confirming that both the
How useful are these addresses? Is there a chance that these will be updated/changed? |
rjan90
approved these changes
Jan 13, 2026
github-project-automation
Bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FOC
wjmelements
requested changes
Jan 13, 2026
Contributor
wjmelements
left a comment
wjmelements
left a comment
There was a problem hiding this comment.
also need to change the tools scripts
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to ⌨️ In Progress
in FOC
Contributor
|
See #364 |
Collaborator
Author
oh gee, I didn't realise these were all used internally. Done in the latest commit. But it's a little invasive and changes how you use the scripts from the outside given that the vars have changed but I don't think that should be a major problem for anyone since these are mainly dev scripts? @rjan90 you'd better take a careful look at these and see if you approve of going this far. |
wjmelements
approved these changes
Jan 13, 2026
github-project-automation
Bot
moved this from ⌨️ In Progress
to ✔️ Approved by reviewer
in FOC
rjan90
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING change because it renames keys here but they are very inconsistent and confusing and the PDP ones don't even show you what the proxy is.
I had to go use this today and was a bit frustrated it was less useful than I imagined.
@rjan90 I got
SIGNATURE_VERIFICATION_LIB_ADDRESSoff a message in Slack from you for calibnet but had to go hunting on the chain for the mainnet one, I'm pretty sure that's it by the bytecode match but you might just want to see if you have a record of that being the right address for mainnet.