Skip to content

fix issues:99#102

Merged
kaola526 merged 7 commits into
mainfrom
hwx/fix-99
May 13, 2026
Merged

fix issues:99#102
kaola526 merged 7 commits into
mainfrom
hwx/fix-99

Conversation

@kaola526
Copy link
Copy Markdown
Contributor

@kaola526 kaola526 commented May 7, 2026

fix #99

Copilot AI review requested due to automatic review settings May 7, 2026 08:36
@FilOzzy FilOzzy added this to FOC May 7, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC May 7, 2026
@rjan90 rjan90 requested a review from silent-cipher May 7, 2026 08:36
@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting review in FOC May 7, 2026
@rjan90 rjan90 requested review from beck-8 and removed request for silent-cipher May 7, 2026 08:37
@rjan90 rjan90 added this to the M4.5: GA Fast Follows milestone May 7, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to address parts of issue #99 by improving navigation UX in the subgraph-client: it changes the “go back” affordance on detail pages to a “go home” link, and it adds a shortcut to route direct provider-address searches to the provider details page.

Changes:

  • Replace GoBackLink with a new GoHomeLink across several pages so the top-left navigation returns to the landing page.
  • Add a provider-address regex check on the landing search flow to navigate directly to the provider details page.
  • Introduce subgraph-client/src/components/go-home.tsx.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
subgraph-client/src/pages/ServiceDetails.tsx Swap back navigation to the new home-link component.
subgraph-client/src/pages/ProviderDetails.tsx Swap back navigation to the new home-link component.
subgraph-client/src/pages/ProofSetDetails.tsx Swap back navigation to the new home-link component.
subgraph-client/src/pages/PieceDetails.tsx Swap back navigation to the new home-link component.
subgraph-client/src/pages/Landing.tsx Add direct-navigation behavior for provider-address searches.
subgraph-client/src/pages/GasCalculator.tsx Swap back navigation to the new home-link component.
subgraph-client/src/pages/Documentation.tsx Swap back navigation to the new home-link component.
subgraph-client/src/components/go-home.tsx New component implementing “Go Home” navigation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread subgraph-client/src/components/go-home.tsx Outdated
Comment thread subgraph-client/src/pages/Landing.tsx Outdated
Comment thread subgraph-client/src/pages/Landing.tsx Outdated
Comment thread subgraph-client/src/components/go-home.tsx Outdated
kaola526 and others added 2 commits May 7, 2026 17:01
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI and others added 2 commits May 7, 2026 09:09
Copy link
Copy Markdown
Contributor

Copilot AI commented May 7, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • accounts.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5490 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.OyCKgg --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,9116235771794877542,12573394795142888474,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10098721347926337431,736684687944402421,4 --trace-process-track-uuid=3190708989122997041 om/FilOzone/pdp---monitor-self-annotation=ptype=crashpad-handler k/pdp-explorer/p--database=/root/.config/google-chrome/Crash Reports (dns block)
    • Triggering command: /usr/bin/chromium-browser chromium-browser --headless --disable-gpu --no-sandbox --screenshot=/tmp/landing-ui.png --window-size=1440,900 REDACTED rgo/bin/git (dns block)
  • api.goldsky.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5490 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.OyCKgg --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,9116235771794877542,12573394795142888474,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10098721347926337431,736684687944402421,4 --trace-process-track-uuid=3190708989122997041 om/FilOzone/pdp---monitor-self-annotation=ptype=crashpad-handler k/pdp-explorer/p--database=/root/.config/google-chrome/Crash Reports (dns block)
    • Triggering command: /usr/bin/chromium-browser chromium-browser --headless --disable-gpu --no-sandbox --screenshot=/tmp/landing-ui.png --window-size=1440,900 REDACTED rgo/bin/git (dns block)
  • clients2.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5490 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.OyCKgg --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,9116235771794877542,12573394795142888474,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10098721347926337431,736684687944402421,4 --trace-process-track-uuid=3190708989122997041 om/FilOzone/pdp---monitor-self-annotation=ptype=crashpad-handler k/pdp-explorer/p--database=/root/.config/google-chrome/Crash Reports (dns block)
    • Triggering command: /usr/bin/chromium-browser chromium-browser --headless --disable-gpu --no-sandbox --screenshot=/tmp/landing-ui.png --window-size=1440,900 REDACTED rgo/bin/git (dns block)
  • redirector.gvt1.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5490 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.OyCKgg --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,9116235771794877542,12573394795142888474,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10098721347926337431,736684687944402421,4 --trace-process-track-uuid=3190708989122997041 om/FilOzone/pdp---monitor-self-annotation=ptype=crashpad-handler k/pdp-explorer/p--database=/root/.config/google-chrome/Crash Reports (dns block)
    • Triggering command: /usr/bin/chromium-browser chromium-browser --headless --disable-gpu --no-sandbox --screenshot=/tmp/landing-ui.png --window-size=1440,900 REDACTED rgo/bin/git (dns block)
  • www.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5490 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.OyCKgg --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,9116235771794877542,12573394795142888474,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10098721347926337431,736684687944402421,4 --trace-process-track-uuid=3190708989122997041 om/FilOzone/pdp---monitor-self-annotation=ptype=crashpad-handler k/pdp-explorer/p--database=/root/.config/google-chrome/Crash Reports (dns block)
    • Triggering command: /usr/bin/chromium-browser chromium-browser --headless --disable-gpu --no-sandbox --screenshot=/tmp/landing-ui.png --window-size=1440,900 REDACTED rgo/bin/git (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copy link
Copy Markdown
Collaborator

@silent-cipher silent-cipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR still doesn’t address the last issue:

  1. There is no button to switch networks on the mobile phone

@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting review to ⌨️ In Progress in FOC May 12, 2026
Copy link
Copy Markdown

@beck-8 beck-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BigLep BigLep moved this from ⌨️ In Progress to 🔎 Awaiting review in FOC May 13, 2026
@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FOC May 13, 2026
@kaola526 kaola526 merged commit 1cd6ab0 into main May 13, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

Interface user experience issues

8 participants