feat(Dogfooding): Add OpenFeature SDK for server-side Flagsmith-on-Flagsmith by khvn26 · Pull Request #7008 · Flagsmith/flagsmith

khvn26 · 2026-03-20T18:59:21Z

I have read the Contributing Guide.
I have added information to docs/ if required so people know about the feature.
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Migrate Flagsmith-on-Flagsmith feature evaluation from the native Flagsmith Python SDK to the vendor-neutral OpenFeature SDK with the Flagsmith provider.

Added openfeature-sdk and openfeature-provider-flagsmith (>=0.1.6), now published on PyPI with flagsmith SDK v5 support.

Replaced get_client() with get_openfeature_client() in integrations/flagsmith/client.py, using OpenFeature's provider registry with a named domain (flagsmith-api) and lazy initialisation via ProviderStatus check.

Replaced flagsmith_identifier + flagsmith_on_flagsmith_api_traits on the Organisation model with a single openfeature_evaluation_context property returning an EvaluationContext.

Migrated all call-sites from client.get_identity_flags(...).is_feature_enabled("x") to client.get_boolean_value("x", default_value=False, evaluation_context=...), including leftover flags.is_feature_enabled() references in organisations/tasks.py and organisations/task_helpers.py.

enable_features test fixture now uses OpenFeature's InMemoryProvider instead of mocking Flagsmith internals. 22 org tasks tests migrated from manual get_openfeature_client mocks to the fixture.

Added openfeature_flagsmith.* and licensing.* to mypy ignore_missing_imports overrides (packages lack py.typed).

How did you test this code?

Made sure existing tests pass.

claude

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.

Once credits are available, reopen this pull request to trigger a review.

vercel · 2026-03-20T18:59:27Z

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs	Ignored	Preview	Apr 2, 2026 11:04am
flagsmith-frontend-preview	Ignored	Preview	Apr 2, 2026 11:04am
flagsmith-frontend-staging	Ignored	Preview	Apr 2, 2026 11:04am

github-actions · 2026-03-20T19:00:27Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-e2e:pr-7008`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-frontend:pr-7008`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-api-test:pr-7008`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api:pr-7008`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-7008`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-7008`	Finished ✅	Results ✅

api/conftest.py

api/pyproject.toml

github-actions · 2026-03-20T19:05:11Z

Playwright Test Results (oss - depot-ubuntu-latest-16)

10 passed

Details

10 tests across 7 suites
43 seconds
11c6b4b
🔄 Run: #15405 (attempt 1)

2 tests across 2 suites
44.1 seconds
f8770f0
🔄 Run: #15643 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
59.9 seconds
f8770f0
🔄 Run: #15643 (attempt 1)

codecov · 2026-03-20T19:14:26Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.33%. Comparing base (cee0c91) to head (f8770f0).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7008      +/-   ##
==========================================
- Coverage   98.33%   98.33%   -0.01%     
==========================================
  Files        1335     1335              
  Lines       49943    49930      -13     
==========================================
- Hits        49113    49100      -13     
  Misses        830      830

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Zaimwa9

Not much too say, I would approve if it wasn't for the dependency update and merge conflicts to come. Good addition overall

api/conftest.py

api/integrations/flagsmith/client.py

Migrate Flagsmith-on-Flagsmith feature evaluation from the native Flagsmith Python SDK to the vendor-neutral OpenFeature SDK with the Flagsmith provider, dogfooding our own OpenFeature integration.

Custom kwargs bypassed get_provider_kwargs() entirely, meaning essential properties like the API key were never set when kwargs were provided.

khvn26 requested a review from a team as a code owner March 20, 2026 18:59

khvn26 requested review from gagantrivedi and removed request for a team March 20, 2026 18:59

claude bot reviewed Mar 20, 2026

View reviewed changes

github-actions bot added api Issue related to the REST API feature New feature or request labels Mar 20, 2026

khvn26 commented Mar 20, 2026

View reviewed changes

api/conftest.py Show resolved Hide resolved

khvn26 commented Mar 20, 2026

View reviewed changes

api/pyproject.toml Show resolved Hide resolved

khvn26 changed the title ~~feat(API): Add OpenFeature SDK for server-side Flagsmith-on-Flagsmith~~ feat: Add OpenFeature SDK for server-side Flagsmith-on-Flagsmith Mar 20, 2026

khvn26 changed the title ~~feat: Add OpenFeature SDK for server-side Flagsmith-on-Flagsmith~~ feat(Dogfooding): Add OpenFeature SDK for server-side Flagsmith-on-Flagsmith Mar 20, 2026

This comment was marked as outdated.

Sign in to view

Zaimwa9 reviewed Mar 23, 2026

View reviewed changes

api/conftest.py Show resolved Hide resolved

khvn26 force-pushed the feat/openfeature-sdk-migration branch from ddf8c99 to 0d6327b Compare March 31, 2026 09:46

github-actions bot added feature New feature or request and removed feature New feature or request labels Mar 31, 2026

khvn26 requested a review from Zaimwa9 March 31, 2026 09:50

Zaimwa9 reviewed Mar 31, 2026

View reviewed changes

api/integrations/flagsmith/client.py Outdated Show resolved Hide resolved

khvn26 added 3 commits April 2, 2026 12:02

feat(API): Add OpenFeature SDK for server-side Flagsmith-on-Flagsmith

4caa029

Migrate Flagsmith-on-Flagsmith feature evaluation from the native Flagsmith Python SDK to the vendor-neutral OpenFeature SDK with the Flagsmith provider, dogfooding our own OpenFeature integration.

deps: Bump openfeature-provider-flagsmith to 0.1.6

22a78ba

fix(API): Remove unused **flagsmith_kwargs from get_openfeature_client

f8770f0

Custom kwargs bypassed get_provider_kwargs() entirely, meaning essential properties like the API key were never set when kwargs were provided.

khvn26 force-pushed the feat/openfeature-sdk-migration branch from 0d6327b to f8770f0 Compare April 2, 2026 11:04

khvn26 requested a review from Zaimwa9 April 2, 2026 11:05

github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 2, 2026

Zaimwa9 approved these changes Apr 2, 2026

View reviewed changes

khvn26 merged commit 3e3be2e into main Apr 2, 2026
36 checks passed

khvn26 deleted the feat/openfeature-sdk-migration branch April 2, 2026 13:31

flagsmithdev mentioned this pull request Apr 2, 2026

chore(main): release 2.226.0 #7106

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Dogfooding): Add OpenFeature SDK for server-side Flagsmith-on-Flagsmith#7008

feat(Dogfooding): Add OpenFeature SDK for server-side Flagsmith-on-Flagsmith#7008
khvn26 merged 3 commits intomainfrom
feat/openfeature-sdk-migration

khvn26 commented Mar 20, 2026 •

edited

Loading

Uh oh!

claude bot left a comment

Uh oh!

vercel bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

Zaimwa9 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

khvn26 commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

How did you test this code?

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Uh oh!

vercel bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docker builds report

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Uh oh!

codecov bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

Uh oh!

Zaimwa9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

khvn26 commented Mar 20, 2026 •

edited

Loading

vercel bot commented Mar 20, 2026 •

edited

Loading

github-actions bot commented Mar 20, 2026 •

edited

Loading

github-actions bot commented Mar 20, 2026 •

edited

Loading

codecov bot commented Mar 20, 2026 •

edited

Loading