Fix overflow buttons styling in Vaadin 25#20
Conversation
A separate style sheet is needed as buttons are in the shadow dom. Close #17
WalkthroughThis PR updates the Day of Week Selector component for Vaadin 25 compatibility by introducing a new theme-scoped CSS stylesheet, updating the component's CSS imports, bumping dependency versions, and adding a test AppShellConfigurator implementation to resolve styling issues with the overflow state. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/main/resources/META-INF/frontend/styles/fc-days-of-week-selector.css`:
- Around line 50-51: The focus-ring override for
vaadin-button.fc-days-of-week-selector-button removes the visible focus
indicator and harms keyboard accessibility; restore a visible focus style by
removing the box-shadow: none override (or replace it with an accessible focus
style) in the vaadin-button.fc-days-of-week-selector-button[focus-ring] rule so
keyboard users can see focus — locate the selector
vaadin-button.fc-days-of-week-selector-button[focus-ring] and either delete that
declaration or set a clear, high-contrast focus outline/box-shadow instead of
none.



Close #17
Summary by CodeRabbit
Chores
Style
✏️ Tip: You can customize this high-level summary in your review settings.