Skip to content

Vaadin 25 support#92

Merged
javier-godoy merged 7 commits intomasterfrom
vaadin-25-support
Feb 3, 2026
Merged

Vaadin 25 support#92
javier-godoy merged 7 commits intomasterfrom
vaadin-25-support

Conversation

@paodb
Copy link
Member

@paodb paodb commented Feb 2, 2026

Summary by CodeRabbit

  • Dependencies

    • Vaadin upgraded to 25.0.3; commons-demo bumped to 5.1.0.
    • Added Lombok (provided), json-migration-helper, and an optional vaadin-dev dependency.
    • Added a Polymer frontend package for improved integration.
  • Chores

    • Updated copyright years across the project.

@coderabbitai
Copy link

coderabbitai bot commented Feb 2, 2026

Walkthrough

Updated build (Vaadin 25.0.3, new dependencies), added Polymer and JsonMigration annotations to OrgChart, introduced a reflection-based test utility, and bumped license headers across source and test files.

Changes

Cohort / File(s) Summary
Build configuration
pom.xml
Bumped <vaadin.version> to 25.0.3, added org.projectlombok:lombok:1.18.34 (provided), com.flowingcode.vaadin:json-migration-helper:0.9.2, introduced optional com.vaadin:vaadin-dev, and updated commons-demo to 5.1.0 (including v25 profile).
Core OrgChart
src/main/java/.../OrgChart.java
Added @NpmPackage("@polymer/polymer","3.5.2") and @ExtensionMethod(JsonMigration.class, suppressBaseMethods = true) annotations and corresponding imports.
Test utilities & usage
src/test/java/.../ReflectionUtil.java, src/test/java/.../EditChartDemo.java
Added ReflectionUtil.setItems(...) (reflection-based wrapper for RadioButtonGroup.setItems) and switched EditChartDemo to use it in conditional blocks for cross-version compatibility.
License header addition
src/main/java/.../event/NodeUpdatedEvent.java
Inserted Apache-2.0 license header at file top.
Minor header/year updates
src/main/java/..., src/main/resources/..., src/test/java/..., src/test/resources/...
Many files updated to bump copyright years (mostly 2025→2026 or 2017-2025→2017-2026); no behavioral changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • javier-godoy
  • mlopezFC
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Vaadin 25 support' directly reflects the main objective of the pull request, which involves updating Vaadin from 25.0.0-beta2 to 25.0.3 and adding related dependencies like json-migration-helper and Lombok.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vaadin-25-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
pom.xml (1)

553-570: ⚠️ Potential issue | 🟡 Minor

Update Vaadin to 25.0.4 (latest patch released Jan 28, 2026).

Vaadin 25.0.4 is available and should be used instead of 25.0.3. The commons-demo 5.1.0 version is appropriate. The vaadin-dev `true flag is correct per Vaadin's recommendation to exclude development-mode tooling from production builds.

🤖 Fix all issues with AI agents
In `@src/main/java/com/flowingcode/vaadin/addons/orgchart/OrgChart.java`:
- Around line 62-70: The build is missing a maven-compiler-plugin configuration
to enable Lombok annotation processing (required for `@ExtensionMethod` on
JsonMigration.class) under Java 21; add the maven-compiler-plugin (e.g., version
3.11.0) to the POM and include annotationProcessorPaths containing the Lombok
coordinates (org.projectlombok:lombok:1.18.34) so the `@ExtensionMethod`
annotation is processed during compilation.

In `@src/test/java/com/flowingcode/vaadin/addons/orgchart/ReflectionUtil.java`:
- Line 5: Update the copyright header in ReflectionUtil.java to match the
project's standard by replacing "Flowing Code" with "Flowing Code S.A." in the
file header (class ReflectionUtil) while preserving the existing year range and
formatting so it matches other files in the PR.
- Line 29: Typo in the Javadoc comment of ReflectionUtil: replace "mantain" with
"maintain". Edit the comment string in the ReflectionUtil class (the /**
Reflective call in order to mantain binary compatibility with Vaadin 14 - 24+ */
Javadoc) to correct the spelling to "maintain" so the documentation reads:
"Reflective call in order to maintain binary compatibility with Vaadin 14 -
24+."
🧹 Nitpick comments (1)
src/test/java/com/flowingcode/vaadin/addons/orgchart/EditChartDemo.java (1)

180-180: Minor formatting: add space after comma for consistency.

Line 207 has proper spacing ReflectionUtil.setItems(typeSelector, "Parent(root)"... but this line is missing the space.

Proposed fix
-    ReflectionUtil.setItems(actionSelector,"Add", "Edit", "Delete");
+    ReflectionUtil.setItems(actionSelector, "Add", "Edit", "Delete");

@paodb paodb force-pushed the vaadin-25-support branch from 692cd78 to 219b65f Compare February 3, 2026 11:41
@paodb paodb marked this pull request as ready for review February 3, 2026 12:33
@paodb paodb requested a review from javier-godoy February 3, 2026 12:33
@paodb paodb requested a review from javier-godoy February 3, 2026 18:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2026

@javier-godoy javier-godoy merged commit a891cfd into master Feb 3, 2026
6 checks passed
@javier-godoy javier-godoy deleted the vaadin-25-support branch February 3, 2026 18:13
@github-project-automation github-project-automation bot moved this to Pending release in Flowing Code Addons Feb 4, 2026
@paodb paodb moved this from Pending release to Done in Flowing Code Addons Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants