Fix Mass Assignments in Leads Endpoint #5668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The endpoint uses
Object.assign()to copy all properties from the request body to the Lead entity without any input validation or field filtering. This allows attackers to bypass auto-generated fields and inject arbitrary values.This PR allows only the fields that are user controlled to be user controlled ('chatflowid', 'name', 'email', 'phone').
Testing
Ran the same
curlrequests that exposed the issue and ensured that the fields likeidandcreatedDatewere generated by the code and not overridden by the request.Example 1:
idExample 2:
createdDatePreviously, the
idandcreatedDatevalue would've been taken from the requests