Use secureFetch in WebScraperTool #5678
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly replaces node-fetch with the custom secureFetch method in WebScraperTool to add SSRF protection, which is a good security improvement. My review includes a suggestion to simplify the call to secureFetch for better code clarity and to remove redundant options.
| private async scrapeSingleUrl(url: string): Promise<Omit<ScrapedPageData, 'url'> & { foundLinks: string[] }> { | ||
| try { | ||
| const response = await fetch(url, { timeout: this.timeoutMs, redirect: 'follow', follow: 5 }) | ||
| const response = await secureFetch(url, { timeout: this.timeoutMs, redirect: 'follow', follow: 5 }) |
Contributor
There was a problem hiding this comment.
The secureFetch function handles redirects manually and overrides the redirect option. The follow option is also not used by secureFetch's internal logic. To avoid confusion and improve clarity, these properties can be removed from the call. secureFetch defaults to a maximum of 5 redirects, which preserves the original behavior of follow: 5.
Suggested change
| const response = await secureFetch(url, { timeout: this.timeoutMs, redirect: 'follow', follow: 5 }) | |
| const response = await secureFetch(url, { timeout: this.timeoutMs }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was using
node-fetchinstead of the custom-builtsecureFetchmethod.secureFetchhas SSRF protection built in and should be the standard used in Flowise when making fetch calls.