fix: update loginmethod endpoints #5681
Open
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request disables the read, create, and update endpoints for loginmethod on the cloud platform by adding platform checks. The implementation is straightforward, but there are opportunities for improvement regarding code consistency and correctness of HTTP status codes. My review includes suggestions to use StatusCodes.FORBIDDEN instead of StatusCodes.BAD_REQUEST for better semantic accuracy, and to place all authorization checks in the controller layer for consistency. These suggestions align with best practices for implementing authorization checks to avoid unintended failures.
packages/server/src/enterprise/controllers/login-method.controller.ts
Outdated
Show resolved
Hide resolved
packages/server/src/enterprise/services/login-method.service.ts
Outdated
Show resolved
Hide resolved
0xi4o
requested review from
HenryHengZJ,
benzhang-wd,
christopherholland-workday,
igor-magun-wd and
simon-song-wd
0xi4o
changed the title
igor-magun-wd
approved these changes
Jan 28, 2026
christopherholland-workday
approved these changes
Jan 28, 2026
packages/server/src/enterprise/controllers/login-method.controller.ts
Outdated
Show resolved
Hide resolved
packages/server/src/enterprise/services/login-method.service.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.