Fix definition of WindowsUserShellFolders#663
Open
panhania wants to merge 1 commit intoForensicArtifacts:mainfrom
Open
Fix definition of WindowsUserShellFolders#663panhania wants to merge 1 commit intoForensicArtifacts:mainfrom
WindowsUserShellFolders#663panhania wants to merge 1 commit intoForensicArtifacts:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
==========================================
- Coverage 69.70% 69.33% -0.37%
==========================================
Files 9 9
Lines 769 763 -6
==========================================
- Hits 536 529 -7
- Misses 233 234 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
thanks for the proposed changes, taking a closer look as soon as time permits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the clarification in #662, I fixed the
WindowsUserShellFoldersartifact:HKEY_USERS\%%users.sid%%\Software\Microsoft\Windows\CurrentVersion\Explorer\Shell FoldersandHKEY_USERS\%%users.sid%%\Environmentcontain no subkeys, only values, so the glob at the end of thekeysattribute will match nothing.HKEY_USERS\%%users.sid%%\Volatile Environmentis a bit different as it contains both values and subkeys (with values), so the glob makes sense given we also include the key itself.