-
Notifications
You must be signed in to change notification settings - Fork 10
Update how type information is passed from Phlex to FORM #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #252 +/- ##
==========================================
- Coverage 76.66% 75.08% -1.58%
==========================================
Files 124 124
Lines 2725 2906 +181
Branches 475 510 +35
==========================================
+ Hits 2089 2182 +93
- Misses 442 503 +61
- Partials 194 221 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Co-authored-by: Copilot <[email protected]>
Given that ROOT knows about the type via their
std::type_info(and their C++ names) and that we can not lookup astd::type_infofrom anstd::type_index(but the reverse is supported by the C++ standard), we need to pass around thetype_info(otherwise we need to build a map of supported types).