Skip to content

Conversation

@pcanal
Copy link
Contributor

@pcanal pcanal commented Jan 13, 2026

Given that ROOT knows about the type via their std::type_info (and their C++ names) and that we can not lookup a std::type_info from an std::type_index (but the reverse is supported by the C++ standard), we need to pass around the type_info (otherwise we need to build a map of supported types).

@pcanal pcanal added this to the F2: Integration release milestone Jan 13, 2026
@pcanal pcanal self-assigned this Jan 13, 2026
@pcanal pcanal added the enhancement New feature or request label Jan 13, 2026
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 26 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
form/root_storage/root_tbranch_container.cpp 24.13% 19 Missing and 3 partials ⚠️
form/storage/storage.cpp 57.14% 2 Missing and 1 partial ⚠️
form/storage/storage_container.cpp 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (75.08%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   76.66%   75.08%   -1.58%     
==========================================
  Files         124      124              
  Lines        2725     2906     +181     
  Branches      475      510      +35     
==========================================
+ Hits         2089     2182      +93     
- Misses        442      503      +61     
- Partials      194      221      +27     
Flag Coverage Δ
unittests 75.08% <50.00%> (-1.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
form/form/form.cpp 74.19% <100.00%> (-2.95%) ⬇️
form/form/form.hpp 100.00% <ø> (ø)
form/form_module.cpp 85.10% <100.00%> (-2.40%) ⬇️
form/persistence/ipersistence.hpp 100.00% <ø> (ø)
form/persistence/persistence.cpp 84.31% <100.00%> (ø)
form/persistence/persistence.hpp 100.00% <ø> (ø)
form/root_storage/root_tbranch_container.hpp 100.00% <ø> (ø)
form/root_storage/root_ttree_container.cpp 46.15% <ø> (ø)
form/storage/istorage.hpp 100.00% <ø> (ø)
form/storage/storage.hpp 100.00% <ø> (ø)
... and 5 more

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c80b5a...c9327bb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant