fix temp files cleanup#122
Merged
Merged
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughA task-local temp directory is created at UploadBlob start, threaded through HandleUpload → AppendAny → GetStream and compression/re-encoding helpers for intermediate files, and removed in a finally block; changelog and project version updated. ChangesTemp Directory Centralization
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@Frends.AzureBlobStorage.UploadBlob/Frends.AzureBlobStorage.UploadBlob/UploadBlob.cs`:
- Around line 191-192: The append-flow is using input.SourceFile which can be
empty for directory-mode uploads; update all calls to AppendAny to pass the
actual file path using fi.FullName instead of input.SourceFile (e.g., replace
the argument in AppendAny(appendBlobClient, blobName, input.SourceFile,
tempDirectory, cancellationToken) and the other two occurrences so they become
AppendAny(appendBlobClient, blobName, fi.FullName, tempDirectory,
cancellationToken)), ensuring the AppendAny invocation uses fi.FullName for
append operations.
- Around line 626-631: The CleanupTempDirectory method currently calls
Directory.Delete and can throw, which may mask upload results; change
CleanupTempDirectory(string tempDirectory) to perform a best-effort delete by
catching and ignoring (or logging) any exceptions from Directory.Delete so it
never throws (do not rethrow), and ensure it still returns void; reference the
method name CleanupTempDirectory and the call to Directory.Delete when locating
the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b04fbd57-640c-4282-b7fe-e00dd1701a2a
📒 Files selected for processing (1)
Frends.AzureBlobStorage.UploadBlob/Frends.AzureBlobStorage.UploadBlob/UploadBlob.cs
Comment on lines
+191
to
+192
| fi = await AppendAny(appendBlobClient, blobName, input.SourceFile, tempDirectory, | ||
| cancellationToken); |
There was a problem hiding this comment.
Use the current file path in append flows (directory mode bug).
Line 191, Line 266, and Line 310 pass input.SourceFile to AppendAny. In directory uploads this can be empty, causing append-on-existing paths to fail. Pass fi.FullName instead.
Suggested fix
- fi = await AppendAny(appendBlobClient, blobName, input.SourceFile, tempDirectory,
+ fi = await AppendAny(appendBlobClient, blobName, fi.FullName, tempDirectory,
cancellationToken);
- fi = await AppendAny(blobClient, blobName, input.SourceFile, tempDirectory, cancellationToken);
+ fi = await AppendAny(blobClient, blobName, fi.FullName, tempDirectory, cancellationToken);
- fi = await AppendAny(pageBlobClient, blobName, input.SourceFile, tempDirectory,
+ fi = await AppendAny(pageBlobClient, blobName, fi.FullName, tempDirectory,
cancellationToken);Also applies to: 266-266, 310-311
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@Frends.AzureBlobStorage.UploadBlob/Frends.AzureBlobStorage.UploadBlob/UploadBlob.cs`
around lines 191 - 192, The append-flow is using input.SourceFile which can be
empty for directory-mode uploads; update all calls to AppendAny to pass the
actual file path using fi.FullName instead of input.SourceFile (e.g., replace
the argument in AppendAny(appendBlobClient, blobName, input.SourceFile,
tempDirectory, cancellationToken) and the other two occurrences so they become
AppendAny(appendBlobClient, blobName, fi.FullName, tempDirectory,
cancellationToken)), ensuring the AppendAny invocation uses fi.FullName for
append operations.
MichalFrends1
requested changes
May 6, 2026
MichalFrends1
requested changes
May 6, 2026
Contributor
MichalFrends1
left a comment
MichalFrends1
left a comment
There was a problem hiding this comment.
Update project version and changelog
MichalFrends1
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Checklist
Summary by CodeRabbit
Refactor
Fix