drop old .net support#252
Conversation
WalkthroughBoth Frends.SFTP.DownloadFiles and Frends.SFTP.UploadFiles projects are consolidating their target frameworks from multi-target setups (.NET 6.0, .NET Standard 2.0, .NET Framework 4.7.1) to single-target .NET 6.0. Version numbers bumped to 4.0.0, with corresponding changelog entries documenting the framework support removal. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Frends.SFTP.DownloadFiles/CHANGELOG.md`:
- Around line 3-7: The changelog entry "## [4.0.0] - 2026-04-26" currently drops
.NET Framework 4.7.1 and .NET Standard 2.0 without upgrade guidance and uses a
future release date; change the header to "[Unreleased]" (replace "## [4.0.0] -
2026-04-26"), mark the note as a Breaking Change (add a "### Breaking Changes"
subsection or prefix the bullet under "### Changed"), and add concise migration
guidance explaining required actions for integrators (e.g., target framework
changes, minimum supported runtimes, code/API compatibility notes and steps to
recompile or migrate) so the entry for the dropped support is explicit and
actionable.
In `@Frends.SFTP.UploadFiles/CHANGELOG.md`:
- Around line 3-7: Update the changelog entry that currently reads "## [4.0.0] -
2026-04-26" and the "Changed" bullet that drops support for .NET Framework 4.7.1
and .NET Standard 2.0: either change the header to "## [Unreleased]" to avoid a
future-dated release, or set a real release date and mark this as a breaking
change by adding a "### Breaking changes" section or a clear upgrade note
explaining migration steps/impact (e.g., which targets are removed and how
consumers should update), ensuring the entry follows Keep a Changelog and
includes explicit upgrade guidance for the compatibility break.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3de73036-69b6-4bfa-be6d-7d5b43354e68
📒 Files selected for processing (5)
Frends.SFTP.DownloadFiles/CHANGELOG.mdFrends.SFTP.DownloadFiles/Frends.SFTP.DownloadFiles/Frends.SFTP.DownloadFiles.csprojFrends.SFTP.UploadFiles/CHANGELOG.mdFrends.SFTP.UploadFiles/Frends.SFTP.UploadFiles.Tests/Frends.SFTP.UploadFiles.Tests.csprojFrends.SFTP.UploadFiles/Frends.SFTP.UploadFiles/Frends.SFTP.UploadFiles.csproj
| ## [4.0.0] - 2026-04-26 | ||
|
|
||
| ### Changed | ||
|
|
||
| - Drop support for .NET Framework 4.7.1 and .NET Standard 2.0. |
There was a problem hiding this comment.
Document this as breaking with explicit migration guidance.
Line 7 is a breaking compatibility change, but the entry lacks upgrade notes. Also, Line 3 is future-dated versus PR timing; use [Unreleased] until release date is real.
Proposed changelog adjustment
-## [4.0.0] - 2026-04-26
+## [4.0.0] - Unreleased
### Changed
-- Drop support for .NET Framework 4.7.1 and .NET Standard 2.0.
+- **Breaking:** Dropped support for .NET Framework 4.7.1 and .NET Standard 2.0.
+
+### Upgrade notes
+- Task now requires .NET 6.0+.
+- Environments on .NET Framework 4.7.1 / .NET Standard 2.0 must remain on 3.x until migrated.As per coding guidelines, Frends.*/CHANGELOG.md must follow Keep a Changelog and include breaking changes with upgrade notes.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## [4.0.0] - 2026-04-26 | |
| ### Changed | |
| - Drop support for .NET Framework 4.7.1 and .NET Standard 2.0. | |
| ## [4.0.0] - Unreleased | |
| ### Changed | |
| - **Breaking:** Dropped support for .NET Framework 4.7.1 and .NET Standard 2.0. | |
| ### Upgrade notes | |
| - Task now requires .NET 6.0+. | |
| - Environments on .NET Framework 4.7.1 / .NET Standard 2.0 must remain on 3.x until migrated. |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Frends.SFTP.DownloadFiles/CHANGELOG.md` around lines 3 - 7, The changelog
entry "## [4.0.0] - 2026-04-26" currently drops .NET Framework 4.7.1 and .NET
Standard 2.0 without upgrade guidance and uses a future release date; change the
header to "[Unreleased]" (replace "## [4.0.0] - 2026-04-26"), mark the note as a
Breaking Change (add a "### Breaking Changes" subsection or prefix the bullet
under "### Changed"), and add concise migration guidance explaining required
actions for integrators (e.g., target framework changes, minimum supported
runtimes, code/API compatibility notes and steps to recompile or migrate) so the
entry for the dropped support is explicit and actionable.
| ## [4.0.0] - 2026-04-26 | ||
|
|
||
| ### Changed | ||
|
|
||
| - Drop support for .NET Framework 4.7.1 and .NET Standard 2.0. |
There was a problem hiding this comment.
Mark this as a breaking release entry and avoid a future-dated release date.
Line 3 uses 2026-04-26 (future relative to this PR), and Line 7 introduces a breaking compatibility change without upgrade notes. Please either keep this under [Unreleased] until release, or set the actual release date and add a clear breaking-change + migration note.
Proposed changelog adjustment
-## [4.0.0] - 2026-04-26
+## [4.0.0] - Unreleased
### Changed
-- Drop support for .NET Framework 4.7.1 and .NET Standard 2.0.
+- **Breaking:** Dropped support for .NET Framework 4.7.1 and .NET Standard 2.0.
+
+### Upgrade notes
+- Consumers must run on .NET 6.0 or newer.
+- If your runtime is .NET Framework 4.7.1 or .NET Standard 2.0, stay on 3.x until migrated.As per coding guidelines, Frends.*/CHANGELOG.md must follow Keep a Changelog and “indicate breaking changes with upgrade notes.”
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## [4.0.0] - 2026-04-26 | |
| ### Changed | |
| - Drop support for .NET Framework 4.7.1 and .NET Standard 2.0. | |
| ## [4.0.0] - Unreleased | |
| ### Changed | |
| - **Breaking:** Dropped support for .NET Framework 4.7.1 and .NET Standard 2.0. | |
| ### Upgrade notes | |
| - Consumers must run on .NET 6.0 or newer. | |
| - If your runtime is .NET Framework 4.7.1 or .NET Standard 2.0, stay on 3.x until migrated. |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Frends.SFTP.UploadFiles/CHANGELOG.md` around lines 3 - 7, Update the
changelog entry that currently reads "## [4.0.0] - 2026-04-26" and the "Changed"
bullet that drops support for .NET Framework 4.7.1 and .NET Standard 2.0: either
change the header to "## [Unreleased]" to avoid a future-dated release, or set a
real release date and mark this as a breaking change by adding a "### Breaking
changes" section or a clear upgrade note explaining migration steps/impact
(e.g., which targets are removed and how consumers should update), ensuring the
entry follows Keep a Changelog and includes explicit upgrade guidance for the
compatibility break.
2 participants
Dear PR creator, please select one of the PR templates, then remove others and this text.
Default PR template
Please review my changes :)
Task Update PR template
Review Checklist
Task Harmonization PR template
Review Checklist
1. Frends Task Project File
Frends.*/Frends.*/*.csproj<TargetFramework>net8.0</TargetFramework><Version>x.0.0</Version><Authors>Frends</Authors><PackageLicenseExpression>MIT</PackageLicenseExpression><GenerateDocumentationFile>true</GenerateDocumentationFile><Description><RepositoryUrl>https://github.com/FrendsPlatform/Frends.SYSTEM/tree/main/Frends.SYSTEM.ACTION</RepositoryUrl><Nullable>disable</Nullable>StyleCop.Analyzers v1.2.0-beta.556FrendsTaskAnalyzers v1.*<Content Include="migration.json" PackagePath="/" Pack="true"/><Content Include="../CHANGELOG.md" PackagePath="/" Pack="true"/><AdditionalFiles Include="FrendsTaskMetadata.json" PackagePath="/" Pack="true"/>2. Frends Task Test Project File
Frends.*/Frends.*.Tests/*.Tests.csproj<TargetFramework>net8.0</TargetFramework><IsPackable>false</IsPackable><Nullable>disable</Nullable>StyleCop.Analyzers v1.2.0-beta.5563. Additional Files
LICENSEfile per repository.gitignorefile per repository.idea/foldersFrends.*/README.mdFrends.*/CHANGELOG.mdFrends.*/Frends.*/FrendsTaskMetadata.jsonFrends.System.Action.System.ActionFrends.*/Frends.*/migration.jsonFrends.*/Frends.*/GlobalSuppressions.csFrends.*/Frends.*.Tests/GlobalSuppressions.cs4. Source Code
5. GitHub Actions Workflows
.github/workflows/*.yml*_release.ymlfeed_api_key: ${{ secrets.TASKS_FEED_API_KEY }}*_test_on_main.ymlbadge_service_api_key: ${{ secrets.BADGE_SERVICE_API_KEY }}*_test_on_push.ymlbadge_service_api_key: ${{ secrets.BADGE_SERVICE_API_KEY }}test_feed_api_key: ${{ secrets.TASKS_TEST_FEED_API_KEY }}GITHUB_TOKENworkdir: Frends.SYSTEM.ACTIONstrict_analyzers: truedotnet_version: 8.0.xprebuild_command: docker-compose up -d)Summary by CodeRabbit