Skip to content

include FrendsTaskMetadata#18

Merged
MatteoDelOmbra merged 1 commit intomainfrom
FSPW-722
Feb 25, 2026
Merged

include FrendsTaskMetadata#18
MatteoDelOmbra merged 1 commit intomainfrom
FSPW-722

Conversation

@MichalFrends1
Copy link
Contributor

@MichalFrends1 MichalFrends1 commented Feb 25, 2026

Please review my changes :)

Review Checklist

  • Task version updated (x.x.0)
  • CHANGELOG.md updated
  • Solution builds
  • Warnings resolved (if possible)
  • Typos resolved
  • Tests cover new code
  • Description how to run tests locally added to README.md (if needed)
  • All tests pass locally

Summary by CodeRabbit

  • Chores
    • Updated package version to 1.10.0 and refined internal project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 25, 2026

Walkthrough

Project configuration updates to how FrendsTaskMetadata.json is packaged and distributed, along with a version bump. The metadata file is now treated as content to be copied to output while also listed as an additional file, and the template package version increments to 1.10.0.

Changes

Cohort / File(s) Summary
Metadata File Packaging
Frends.Echo.Execute/Frends.Echo.Execute/Frends.Echo.Execute.csproj
FrendsTaskMetadata.json converted from AdditionalFiles to Content with CopyToOutputDirectory set to PreserveNewest, then re-added as AdditionalFiles entry without Pack attributes for dual inclusion in output and package.
Version Bump
FrendsTaskTemplate.csproj
PackageVersion updated from 1.9.0 to 1.10.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • MatteoDelOmbra

Poem

🐰 A metadata file hops from here to there,
Now content and additional, a dual affair!
With version bumped high to one-ten so neat,
The template's packaging is now complete!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'include FrendsTaskMetadata' is vague and does not clearly convey what changes were made. It's unclear whether this refers to adding, updating, or modifying the FrendsTaskMetadata file. Provide a more descriptive title that clarifies the specific change, such as 'Update FrendsTaskMetadata handling in project configuration' or 'Copy FrendsTaskMetadata to output directory'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch FSPW-722

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Frends.Template/Frends.Echo.Execute/Frends.Echo.Execute/Frends.Echo.Execute.csproj (1)

40-40: Consider adding Pack="false" to the AdditionalFiles entry for clarity.

AdditionalFiles items are not packed by NuGet by default, so there is no functional issue. However, an explicit Pack="false" makes it immediately clear that this entry is solely for Roslyn analyzer input (i.e., FrendsTaskAnalyzers) and not for packaging, avoiding any ambiguity for future maintainers.

♻️ Proposed change
-		<AdditionalFiles Include="FrendsTaskMetadata.json" />
+		<AdditionalFiles Include="FrendsTaskMetadata.json" Pack="false" />
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@Frends.Template/Frends.Echo.Execute/Frends.Echo.Execute/Frends.Echo.Execute.csproj`
at line 40, The <AdditionalFiles Include="FrendsTaskMetadata.json" /> entry
should be marked explicitly as non-packable; update the MSBuild item to include
Pack="false" on the AdditionalFiles item (the element that references
FrendsTaskMetadata.json) so it’s clear this file is only for analyzers and not
for NuGet packaging.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@Frends.Template/Frends.Echo.Execute/Frends.Echo.Execute/Frends.Echo.Execute.csproj`:
- Line 40: The <AdditionalFiles Include="FrendsTaskMetadata.json" /> entry
should be marked explicitly as non-packable; update the MSBuild item to include
Pack="false" on the AdditionalFiles item (the element that references
FrendsTaskMetadata.json) so it’s clear this file is only for analyzers and not
for NuGet packaging.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 242bfb1 and 2c28428.

📒 Files selected for processing (2)
  • Frends.Template/Frends.Echo.Execute/Frends.Echo.Execute/Frends.Echo.Execute.csproj
  • FrendsTaskTemplate.csproj

@MatteoDelOmbra MatteoDelOmbra merged commit 6ff69ac into main Feb 25, 2026
4 checks passed
@MatteoDelOmbra MatteoDelOmbra deleted the FSPW-722 branch February 25, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants