Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new internal failure classification mechanism by emitting an X-CDN-Internal-Status response header and documenting a 3000–3999 internal status code range to disambiguate runtime failure reasons behind existing 5xx status codes.
Changes:
- Adds internal status code constants (3000–3999) and a new
X-Cdn-Internal-Statusheader constant. - Extends error mapping to return an internal status code and attempts to attach it to error responses.
- Updates executor HTTP tests and README documentation to cover/describe the new header.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
crates/http-service/src/lib.rs |
Adds internal status constants and attempts to set X_CDN_INTERNAL_STATUS on error responses. |
crates/http-service/src/executor/http.rs |
Updates tests to assert presence/value of the new internal status header for timeout/OOM. |
README.md |
Documents internal status code meanings and the header contract. |
Comments suppressed due to low confidence (1)
crates/http-service/src/lib.rs:365
- Because
app_res_headers(cfg)is folded into the response builder afterX-CDN-Internal-Statusis set, a configured app response header with the same name could append a second value and make the internal status ambiguous for downstream consumers. IfX-CDN-Internal-Statusis meant to be authoritative, set/overwrite it after applying app headers (or insert it into the built response’sHeaderMapwithinsertand optionally remove any existing values).
let builder = hyper::Response::builder()
.status(status_code)
.header(X_CDN_INTERNAL_STATUS, internal_code);
let res_headers = app_res_headers(cfg);
let builder = res_headers
.iter()
.fold(builder, |builder, (k, v)| builder.header(k, v));
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qrdl
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.