Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request addresses potential panic issues in the nginx_module by replacing borrow_mut() calls with try_borrow_mut() throughout the unix_socket implementation. This defensive programming approach prevents runtime panics when RefCell borrows fail due to re-entrant calls or concurrent access patterns in the nginx event loop.
Changes:
- Introduced
log_borrow_mut_errorhelper function to standardize error logging for borrow failures - Replaced all
borrow_mut()calls withtry_borrow_mut()in critical paths (connect, disconnected, stop, write, on_read, on_reconnect_timeout) - Version bumped from 0.1.5 to 0.1.6
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nginx_module/src/unix_socket.rs | Systematic conversion of borrow_mut() to try_borrow_mut() with error handling; added log_borrow_mut_error helper function for consistent error logging across all borrow failure cases |
| nginx_module/Cargo.toml | Version bump from 0.1.5 to 0.1.6 to reflect the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qrdl
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.