Palette cli #344
Open
Palette cli #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
najlkin
reviewed
Jun 4, 2025
| args.AddOption(&script_file, "-run", "--run-script", | ||
| "Run a GLVis script file."); | ||
| args.AddOption(&palette_file, "-pal", "--palettes", | ||
| args.AddOption(&palette_file, "-pfile", "--palette-file", |
Contributor
There was a problem hiding this comment.
I am not sure about this one. Palettes with -pal were already in the release, so we should keep backward compatibility maybe.
Contributor
Author
There was a problem hiding this comment.
I think this makes more sense but you're right it breaks compatibility. Do you have any suggestions?
Contributor
Author
There was a problem hiding this comment.
-pname and -palette-name?
Contributor
|
How about script and stream commands. Could you add them too? 😉 If you branch this from #335 , it would be very easy. It makes sense especially with palette files, because it is not that easy to sort out what will be the index when loaded to GLVis. |
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-palor-palette-pfileor-palette-filePaletteState.SetFallbackIndex()overPaletteState.SetIndex()to specify a fallback index if the default is not specified (implementation would have been more invasive viaPaletteStateso it is done through the globalBasePalettes)