Potential fix for code scanning alert no. 6: Workflow does not contain permissions#30
Merged
Potential fix for code scanning alert no. 6: Workflow does not contain permissions#30
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 6 6
=========================================
Hits 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/GalacticDynamics/is_annotated/security/code-scanning/6
To fix the problem, we should add a
permissionsblock to thedistjob in the workflow file.github/workflows/cd.yml. Since this job is for building distributions and does not require any special token privileges (it just checks out source code and runs build steps), we can safely set the permissions to the minimal possible, which iscontents: read. This restricts theGITHUB_TOKENto read-only access to repository contents, preventing accidental code or secret leaks and adhering to the principle of least privilege.Steps:
.github/workflows/cd.yml.distjob (underjobs: dist:), add apermissions:block withcontents: read, at the same indentation level as the other job properties (such asnameandruns-on).Suggested fixes powered by Copilot Autofix. Review carefully before merging.