Open
Conversation
lbeltrame
suggested changes
Dec 10, 2025
| ) | ||
|
|
||
| # Function to parse character vectors | ||
| parse_numeric_vector <- function(str_value) { |
There was a problem hiding this comment.
This has the same problems as the previous PR. The right fix is to use proper parameters in the functions and tell users (as in code users, not actual users) to adapt to those. Blind string parsing will break eventually and is in general very brittle.
| } | ||
| # Remove "c(" and ")" if present | ||
| str_value <- gsub("^c\\(", "", str_value) | ||
| str_value <- gsub("\\)$", "", str_value) |
There was a problem hiding this comment.
What happens if the string is not properly formatted? This is an example of what I wrote above, invalid input will create just more errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.